Re: [mminit] [ INFO: possible recursive locking detected ]

From	Konstantin Khlebnikov <koct9i@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [mminit] [ INFO: possible recursive locking detected ]
Date	2015-07-17 07:10 +0200
Message-ID	<pN64h-41z-1@gated-at.bofh.it> (permalink)
References	<pLW6Z-3CP-3@gated-at.bofh.it> <pM5N0-11t-17@gated-at.bofh.it> <pMUZc-4Ke-17@gated-at.bofh.it> <pMVBU-5ug-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 16, 2015 at 8:51 PM, Mel Gorman <mgorman@suse.de> wrote:
> On Thu, Jul 16, 2015 at 08:13:38PM +0300, Konstantin Khlebnikov wrote:
>> > @@ -1187,14 +1195,14 @@ void __init page_alloc_init_late(void)
>> >  {pgdat_init_rwsempgdat_init_rwsempgdat_init_rwsem
>> >         int nid;
>> >
>> > +       /* There will be num_node_state(N_MEMORY) threads */
>> > +       atomic_set(&pgdat_init_n_undone, num_node_state(N_MEMORY));
>> >         for_each_node_state(nid, N_MEMORY) {
>> > -               down_read(&pgdat_init_rwsem);
>>
>> Rw-sem have special "non-owner" mode for keeping lockdep away.
>> This should be enough:
>>
>
> I think in this case that the completions look nicer though so I think
> I'll keep them.

Ok. Not a big deal, they are anyway in init sections.

BTW there's another option: wait_on_atomic_t / wake_up_atomic_t
like wait_on_bit but atomic_t

>
> --
> Mel Gorman
> SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [mminit] [ INFO: possible recursive locking detected ] Konstantin Khlebnikov <koct9i@gmail.com> - 2015-07-16 19:20 +0200
  Re: [mminit] [ INFO: possible recursive locking detected ] Peter Zijlstra <peterz@infradead.org> - 2015-07-16 19:40 +0200
  Re: [mminit] [ INFO: possible recursive locking detected ] Mel Gorman <mgorman@suse.de> - 2015-07-16 20:00 +0200
    Re: [mminit] [ INFO: possible recursive locking detected ] Konstantin Khlebnikov <koct9i@gmail.com> - 2015-07-17 07:10 +0200

csiph-web