Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1186316

Re: [PATCH] mm-move-mremap-from-file_operations-to-vm_operations_struct-fix

Show all headers | View raw

On Fri, 17 Jul 2015 01:14:05 +0200 Oleg Nesterov <oleg@redhat.com> wrote:

> fs/aio.c can't be compiled if CONFIG_MMU=n, filemap_page_mkwrite()
> is not defined in this case. Add yet another "must not be called"
> helper into nommu.c to make the linker happy.
> 
> I still think this is pointless, afaics sys_io_setup() simply can't
> succeed if CONFIG_MMU=n. Instead we should make CONFIG_AIO depend
> on CONFIG_MMU.
> 
> ..
>
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
> @@ -2008,6 +2008,12 @@ void filemap_map_pages(struct vm_area_struct *vma, struct vm_fault *vmf)
>  }
>  EXPORT_SYMBOL(filemap_map_pages);
>  
> +int filemap_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
> +{
> +	BUG();
> +	return 0;
> +}
> +
>  static int __access_remote_vm(struct task_struct *tsk, struct mm_struct *mm,
>  		unsigned long addr, void *buf, int len, int write)
>  {

So if anyone starts testing aio on NOMMU, this patch will make the
whole thing immediately go BUG.  This isn't helpful :(

Yes, making AIO depend on MMU sounds better.  Because if it wasn't
busted before, it sure is now!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH]  mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Oleg Nesterov <oleg@redhat.com> - 2015-07-17 01:20 +0200
  Re: [PATCH]  mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Andrew Morton <akpm@linux-foundation.org> - 2015-07-17 01:30 +0200
    Re: [PATCH]  mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Oleg Nesterov <oleg@redhat.com> - 2015-07-17 02:00 +0200
      Re: [PATCH] mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Benjamin LaHaise <bcrl@kvack.org> - 2015-07-17 16:10 +0200
        Re: [PATCH]  mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Oleg Nesterov <oleg@redhat.com> - 2015-07-18 00:40 +0200
          Re: [PATCH]  mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Oleg Nesterov <oleg@redhat.com> - 2015-07-20 19:40 +0200
            Re: [PATCH] mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Benjamin LaHaise <bcrl@kvack.org> - 2015-07-20 20:00 +0200
              Re: [PATCH]  mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Oleg Nesterov <oleg@redhat.com> - 2015-07-20 20:40 +0200
              Re: [PATCH] mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Jeff Moyer <jmoyer@redhat.com> - 2015-07-20 20:40 +0200
        Re: [PATCH]  mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Oleg Nesterov <oleg@redhat.com> - 2015-07-18 01:00 +0200
  Re: [PATCH]  mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Stephen Rothwell <sfr@canb.auug.org.au> - 2015-07-17 01:30 +0200

csiph-web