Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1184679

RE: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support

Show key headers only | View raw

Hi Arnd,

Thanks for your review.
And can you give me more information?
In my opinion, The fsl_edma_pm_state will just be used when CONFIG_PM support. So why not use the #ifdefs to remove the 
unnecessary code? Since the PM will not be selected in many use cases.

Thanks.

Best Regards,
Yuan Yao

> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Wednesday, July 15, 2015 5:57 PM
> To: linux-arm-kernel@lists.infradead.org
> Cc: Yuan Yao-B46683; vinod.koul@intel.com; stefan@agner.ch;
> dmaengine@vger.kernel.org; dan.j.williams@intel.com; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support
> 
> On Wednesday 15 July 2015 17:32:58 Yuan Yao wrote:
> > +#ifdef CONFIG_PM
> > +enum fsl_edma_pm_state {
> > +       RUNNING = 0,
> > +       SUSPENDED,
> > +};
> > +#endif
> >
> >  struct fsl_edma_hw_tcd {
> >
> 
> The #ifdefs here seem unnecessary, at least most of them, better just do this
> all unconditionally.
> 
> 	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

(none) Yuan Yao <yao.yuan@freescale.com> - 2015-07-15 11:40 +0200
  [PATCH] dmaengine: fsl-edma: add PM suspend/resume support Yuan Yao <yao.yuan@freescale.com> - 2015-07-15 11:40 +0200
    Re: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support Arnd Bergmann <arnd@arndb.de> - 2015-07-15 12:00 +0200
      RE: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support Yao Yuan <yao.yuan@freescale.com> - 2015-07-15 12:40 +0200
        Re: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support Arnd Bergmann <arnd@arndb.de> - 2015-07-15 17:00 +0200
    RE: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support Yao Yuan <yao.yuan@freescale.com> - 2015-07-17 08:00 +0200

csiph-web