Re: [PATCH 1/2] gpio: altera: use of_mm_gpiochip_remove() to fix memory leak

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] gpio: altera: use of_mm_gpiochip_remove() to fix memory leak
Date	2015-07-15 11:50 +0200
Message-ID	<pMrua-3G9-3@gated-at.bofh.it> (permalink)
References	<pCkki-Ub-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 17, 2015 at 1:59 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> This driver calls of_mm_gpiochip_add() to add a memory mapped gpio
> chip.  So, of_mm_gpiochip_remove() should be used when removing it.
>
> The direct call of gpiochip_remove() misses unmapping the register
> and freeing the label.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Patch applied with the ACKs.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] gpio: altera: use of_mm_gpiochip_remove() to fix  memory leak Linus Walleij <linus.walleij@linaro.org> - 2015-07-15 11:50 +0200

csiph-web