Re: [PATCH 05/10] Staging: fbtft: Set bus specific ops using separate functions

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/10] Staging: fbtft: Set bus specific ops using separate functions
Date	2015-07-15 04:20 +0200
Message-ID	<pMksF-29i-11@gated-at.bofh.it> (permalink)
References	<pGXwK-2qQ-3@gated-at.bofh.it> <pGXwK-2qQ-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 30, 2015 at 08:43:12AM +0200, Fabio Falzoi wrote:
> Use two separate functions for spi and platform bus
> (flexfb_set_spi_bus_func and flexfb_set_platform_bus_func,
> respectively) to set the appropriate write operations.
> 
> This patch corrects the following checkpatch errors:
> WARNING:LONG_LiINE at lines 446, 450, 466, 476, 489 and 495.
> CHECK:PARENTHESIS_ALIGNMENT at line 459.
> 
> Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>

Can't you fix the line lengths without having to move to separate
functions?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 05/10] Staging: fbtft: Set bus specific ops using  separate functions Greg KH <gregkh@linuxfoundation.org> - 2015-07-15 04:20 +0200

csiph-web