Re: [patch] sched: beef up wake_wide()

From	Josef Bacik <jbacik@fb.com>
Newsgroups	linux.kernel
Subject	Re: [patch] sched: beef up wake_wide()
Date	2015-07-14 18:10 +0200
Message-ID	<pMaWl-5cM-9@gated-at.bofh.it> (permalink)
References	(7 earlier) <pM8KS-2MT-17@gated-at.bofh.it> <pM94e-39U-19@gated-at.bofh.it> <pM9dT-3dh-7@gated-at.bofh.it> <pMa0h-3Rk-1@gated-at.bofh.it> <pMaCZ-4AR-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/14/2015 11:39 AM, Mike Galbraith wrote:
> On Tue, 2015-07-14 at 17:04 +0200, Peter Zijlstra wrote:
>> On Tue, Jul 14, 2015 at 04:17:46PM +0200, Mike Galbraith wrote:
>>> There's a buglet,
>>
>>> We'll not look for a idle cpu when wake_wide() naks want_affine.
>>
>> *sigh* indeed.. fixing that'll bring us very close to what we started
>> out wiht..
>>
>> The one XXX there raises the question on whether we should always so
>> select_idle_sibling() if we do not have a suitable balance flag, or only
>> on wakeups.
>
> That's what I've been sitting here waffling over, finally convinced
> myself that should the user turn FORX/EXEC off, he shouldn't find that a
> substitute quietly slipped in.. though otoh.. crap, guess I'm not done
> waffling after all.  Yeah, this will work just fine ;-)
>
> (typos fixed)
>

We happy with this or should I wait for more patches to fly by before I 
test something ;)?

Josef

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [patch] sched: beef up wake_wide() Peter Zijlstra <peterz@infradead.org> - 2015-07-14 17:10 +0200
  Re: [patch] sched: beef up wake_wide() Mike Galbraith <umgwanakikbuti@gmail.com> - 2015-07-14 17:50 +0200
    Re: [patch] sched: beef up wake_wide() Josef Bacik <jbacik@fb.com> - 2015-07-14 18:10 +0200

csiph-web