Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1186238
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2 V5] regmap: Apply optional delay in multi_reg_write/register_patch |
| Date | 2015-07-16 23:00 +0200 |
| Message-ID | <pMYq6-14c-1@gated-at.bofh.it> (permalink) |
| References | <pMTqq-2pX-15@gated-at.bofh.it> <pMTqq-2pX-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Thu, Jul 16, 2015 at 04:36:22PM +0100, Nariman Poushin wrote: > + > + if (regs[i].delay_us) > + udelay(regs[i].delay_us); This is a bit funky. While Takashi is correct that we could be running in a spinlock equally this will mean that we could end up with some really long busy waits. It feels like we should at least make an effort to complain about that, print a warning or something.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/2 V5] regmap: Apply optional delay in multi_reg_write/register_patch Nariman Poushin <nariman@opensource.wolfsonmicro.com> - 2015-07-16 17:40 +0200 Re: [PATCH 2/2 V5] regmap: Apply optional delay in multi_reg_write/register_patch Mark Brown <broonie@kernel.org> - 2015-07-16 23:00 +0200 Applied "regmap: Apply optional delay in multi_reg_write/register_patch" to the regmap tree Mark Brown <broonie@kernel.org> - 2015-07-16 23:10 +0200
csiph-web