Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1186230

Re: [PATCH 5/5] regulator: 88pm800: Add support for configuration of dual phase on BUCK1

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 5/5] regulator: 88pm800: Add support for configuration of dual phase on BUCK1
Date 2015-07-16 22:40 +0200
Message-ID <pMY6J-HC-5@gated-at.bofh.it> (permalink)
References <pMVVf-66m-7@gated-at.bofh.it> <pMW4X-6hv-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, Jul 16, 2015 at 11:46:58PM +0530, Vaibhav Hiremath wrote:

>  	.disable		= regulator_disable_regmap,
>  	.is_enabled		= regulator_is_enabled_regmap,
>  	.get_current_limit	= pm800_get_current_limit,
> +	.set_current_limit	= pm800_set_current_limit,

set_current_limit() isn't the right interface to use for this, this is
something that depends on the physical design of the system rather than
something that limits the current.  It should be a DT property of its
own.  There are some other PMICs with similar functions but it's not
clear yet how generic the configuration mechanism is.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/5] regulator: 88pm800: Add 88pm860 regulator support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-16 20:30 +0200
  [PATCH 2/5] regulator: 88pm800: Update driver to use devm_regulator_register fn Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-16 20:30 +0200
  [PATCH 4/5] regulator: 88pm800: Add 88pm860 regulator support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-16 20:30 +0200
    Re: [PATCH 4/5] regulator: 88pm800: Add 88pm860 regulator support Mark Brown <broonie@kernel.org> - 2015-07-16 23:40 +0200
      Re: [PATCH 4/5] regulator: 88pm800: Add 88pm860 regulator support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-17 07:50 +0200
        Re: [PATCH 4/5] regulator: 88pm800: Add 88pm860 regulator support Mark Brown <broonie@kernel.org> - 2015-07-17 13:20 +0200
          Re: [PATCH 4/5] regulator: 88pm800: Add 88pm860 regulator support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-17 14:50 +0200
  [PATCH 5/5] regulator: 88pm800: Add support for configuration of dual phase on BUCK1 Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-16 20:30 +0200
    Re: [PATCH 5/5] regulator: 88pm800: Add support for configuration of  dual phase on BUCK1 Mark Brown <broonie@kernel.org> - 2015-07-16 22:40 +0200
      Re: [PATCH 5/5] regulator: 88pm800: Add support for configuration  of dual phase on BUCK1 Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-17 07:40 +0200

csiph-web