Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1186157

Re: [PATCH v9 07/22] tracing: Add lock-free tracing_map

Show all headers | View raw

On Thu, Jul 16, 2015 at 12:22:40PM -0500, Tom Zanussi wrote:
> +	for (i = 0; i < elt->map->n_fields; i++) {
> +		atomic64_set(&dup_elt->fields[i].sum,
> +			     atomic64_read(&elt->fields[i].sum));
> +		dup_elt->fields[i].cmp_fn = elt->fields[i].cmp_fn;
> +	}
> +
> +	return dup_elt;
> +}

So there is a lot of atomic64_{set,read}() in this patch set, what kind
of magic properties do you assume they have?

Note that atomic*_{set,read}() are weaker than {WRITE,READ}_ONCE(), so
if you're assuming they do that, you're mistaken -- although it is on a
TODO list someplace to go fix that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v9 00/22] tracing: 'hist' triggers Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-16 19:30 +0200
  [PATCH v9 09/22] tracing: Add hist trigger support for multiple values ('vals=' param) Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-16 19:30 +0200
  [PATCH v9 01/22] tracing: Update cond flag when enabling or disabling a trigger Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-16 19:30 +0200
  [PATCH v9 15/22] tracing: Add hist trigger 'sym' and 'sym-offset' modifiers Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-16 19:30 +0200
  [PATCH v9 16/22] tracing: Add hist trigger 'execname' modifier Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-16 19:30 +0200
  [PATCH v9 11/22] tracing: Add hist trigger support for user-defined sorting ('sort=' param) Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-16 19:30 +0200
  [PATCH v9 12/22] tracing: Add hist trigger support for pausing and continuing a trace Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-16 19:30 +0200
    Re: [PATCH v9 12/22] tracing: Add hist trigger support for pausing  and continuing a trace Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> - 2015-07-22 10:30 +0200
  [PATCH v9 08/22] tracing: Add 'hist' event trigger command Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-16 19:30 +0200
    Re: [PATCH v9 08/22] tracing: Add 'hist' event trigger command Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> - 2015-07-20 15:40 +0200
  [PATCH v9 14/22] tracing: Add hist trigger 'hex' modifier for displaying numeric fields Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-16 19:30 +0200
  [PATCH v9 17/22] tracing: Add hist trigger 'syscall' modifier Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-16 19:30 +0200
  [PATCH v9 04/22] tracing: Add event record param to trigger_ops.func() Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-16 19:30 +0200
  [PATCH v9 05/22] tracing: Add get_syscall_name() Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-16 19:30 +0200
  Re: [PATCH v9 07/22] tracing: Add lock-free tracing_map Peter Zijlstra <peterz@infradead.org> - 2015-07-16 20:00 +0200
    Re: [PATCH v9 07/22] tracing: Add lock-free tracing_map Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-16 23:50 +0200
      Re: [PATCH v9 07/22] tracing: Add lock-free tracing_map Peter Zijlstra <peterz@infradead.org> - 2015-07-17 00:40 +0200
        Re: [PATCH v9 07/22] tracing: Add lock-free tracing_map Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-17 04:00 +0200
  Re: [PATCH v9 07/22] tracing: Add lock-free tracing_map Peter Zijlstra <peterz@infradead.org> - 2015-07-16 20:10 +0200
    Re: [PATCH v9 07/22] tracing: Add lock-free tracing_map Tom Zanussi <tom.zanussi@linux.intel.com> - 2015-07-16 23:40 +0200

csiph-web