Re: Checkpatch: False positive

From	Andy Whitcroft <apw@canonical.com>
Newsgroups	linux.kernel
Subject	Re: Checkpatch: False positive
Date	2015-07-16 19:30 +0200
Message-ID	<pMV8S-4VI-13@gated-at.bofh.it> (permalink)
References	<pMP3s-4oJ-13@gated-at.bofh.it> <pMTqr-2pX-37@gated-at.bofh.it> <pMTA7-2Br-29@gated-at.bofh.it> <pMTJM-2N2-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 16, 2015 at 08:58:56AM -0700, Joe Perches wrote:
> On Thu, 2015-07-16 at 16:43 +0100, Andy Whitcroft wrote:
> > On Thu, Jul 16, 2015 at 08:35:58AM -0700, Joe Perches wrote:
> > > > #31: 
> > > >  arch/x86/kernel/hpet.c         | 198 ++++++++++++++++++++++++++---------------
> > 
> > I guess those are in the limbo land between the end of message and
> > beginning of the patch itself.  Perhaps the test should at least stop at
> > the end of header marker, at the '---'.
> > 
> > -apw
> 
> Maybe, but the test already stops at signatures like
> Signed-off-by: that should always be above the ---.
> 
> This might help, but there are _many_ false positives.
> 
> The other thing that might help is for people to take
> the warnings the script produces less seriously.
> 
> Maybe convert:
> 
> ERROR -> defect
> WARNING -> unstylish
> CHECK -> nitpick

Heh, that has long been the main issue, please please believe your brain
not checkpatch.  But yes some less inflamitory words might, just might,
reduce the noise.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Checkpatch: False positive Viresh Kumar <viresh.kumar@linaro.org> - 2015-07-16 13:00 +0200
  Re: Checkpatch: False positive Joe Perches <joe@perches.com> - 2015-07-16 17:40 +0200
    Re: Checkpatch: False positive Andy Whitcroft <apw@canonical.com> - 2015-07-16 17:50 +0200
      Re: Checkpatch: False positive Joe Perches <joe@perches.com> - 2015-07-16 18:00 +0200
        Re: Checkpatch: False positive Andy Whitcroft <apw@canonical.com> - 2015-07-16 19:30 +0200

csiph-web