Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1186083

Re: [PATCH v2 19/20] xen/privcmd: Add support for Linux 64KB page granularity

Show all headers | View raw

On Thu, 16 Jul 2015, Stefano Stabellini wrote:
> > +	/* setup_hparams guarantees ret == 0 */
> > +	BUG_ON(xen_apply_to_page(page, setup_hparams, info));
> > +
> > +	set_xen_guest_handle(xatp.idxs, info->h_idxs);
> > +	set_xen_guest_handle(xatp.gpfns, info->h_gpfns);
> > +	set_xen_guest_handle(xatp.errs, info->h_errs);
> > +	xatp.size = info->h_iter;
> > +
> > +	rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap_range, &xatp);
> 
> I would have thought that XENMEM_add_to_physmap_range operates at 4K
> granularity, regardless of how the guest decides to layout its
> pagetables. If so, the call to XENMEM_add_to_physmap_range needs to be
> moved within the function passed to xen_apply_to_page.

Sorry, this comment is wrong, please ignore it. The others are OK.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 19/20] xen/privcmd: Add support for Linux 64KB page  granularity Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-07-16 19:20 +0200
  Re: [PATCH v2 19/20] xen/privcmd: Add support for Linux 64KB page  granularity Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-07-16 19:20 +0200
  Re: [Xen-devel] [PATCH v2 19/20] xen/privcmd: Add support for Linux  64KB page granularity Julien Grall <julien.grall@citrix.com> - 2015-07-17 15:00 +0200

csiph-web