Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1186072

Re: [PATCH] Staging: drivers: dgnc

Show all headers | View raw

On Fri, Jul 17, 2015 at 12:20:42AM +0000, Craig Inches wrote:
> Hi Joe,
> 
> On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote:
> > On Thu, 2015-07-16 at 23:11 +0000, Craig Inches wrote:
> > > Fixed up some checkpatch.pl style issues.
> > > Line greater than 80 Chars in multiple locations.
> > 
> > I think most all of these are not improvements.
> 	Ok, can you be a little more specific? I did see some that where
> 	not worth modifying due to only being 1 or 2 chars over, and
> 	breaking the line seemed pointless.
> 
> > Please use --strict when verifying your patches.
> 	Not sure where the --strict should be set? I cant see the option
> 	in  the checklist.pl script 
	found it missed the line after --subjective with -h  
	I shall take another crack at a patch, I see some issues
	introduced which wern't reported with just a normal
	checkpatch.pl run.

> > Please fix the time on your systemp.
> 	Thanks for pointing that out, my mail servers time was out.
> 
> Thanks for your feedback.
> Craig

-- 
Craig Inches

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: drivers: dgnc Craig Inches <craig.inches@xayto.net> - 2015-07-16 17:20 +0200
  Re: [PATCH] Staging: drivers: dgnc Joe Perches <joe@perches.com> - 2015-07-16 17:40 +0200
    Re: [PATCH] Staging: drivers: dgnc Craig Inches <craig.inches@navitas.com> - 2015-07-16 18:50 +0200
      Re: [PATCH] Staging: drivers: dgnc Craig Inches <Craig.Inches@xayto.net> - 2015-07-16 19:00 +0200
      Re: [PATCH] Staging: drivers: dgnc Joe Perches <joe@perches.com> - 2015-07-16 20:00 +0200
  Re: [PATCH] Staging: drivers: dgnc Greg KH <gregkh@linuxfoundation.org> - 2015-07-16 18:00 +0200

csiph-web