Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1186049

Re: [PATCH 2/2] ARM: xip: Use correct symbol for end of ROM marker

Show all headers | View raw

On Thu, Jul 16, 2015 at 10:37:14AM -0400, Chris Brandt wrote:
> For an XIP build, _edata_loc, not _etext, is the end of constant R/O
> memory that needs to be mapped into the MODULES_VADDR area. This fixes
> the bug where you might loose part of your R/O data after page table
> setup is complete.

That's not correct.  _etext is set in the linker script to be the end of
the text + readonly data + exception table + unwinder tables + notes.
_edata_loc is the end address of the read/write data section stored in
read-only memory, which exists to be copied by the early kernel assembly
code to RAM.  There's no need for that to remain mapped.

I think you need to either provide more details of the problem you're
seeing, or further reasoning why this is a correct change.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] ARM: xip: Use correct symbol for end of ROM marker Chris Brandt <chris.brandt@renesas.com> - 2015-07-16 16:40 +0200
  Re: [PATCH 2/2] ARM: xip: Use correct symbol for end of ROM marker Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-07-16 18:20 +0200
    RE: [PATCH 2/2] ARM: xip: Use correct symbol for end of ROM marker Chris Brandt <Chris.Brandt@renesas.com> - 2015-07-16 18:30 +0200

csiph-web