Re: [Xen-devel] [PATCH v2 04/20] xen/grant: Add helper gnttab_page_grant_foreign_access_ref

From	Julien Grall <julien.grall@citrix.com>
Newsgroups	linux.kernel
Subject	Re: [Xen-devel] [PATCH v2 04/20] xen/grant: Add helper gnttab_page_grant_foreign_access_ref
Date	2015-07-16 18:20 +0200
Message-ID	<pMU38-3pg-3@gated-at.bofh.it> (permalink)
References	<pKqVz-4Ye-3@gated-at.bofh.it> <pKqVA-4Ye-23@gated-at.bofh.it> <pMSXn-1Ro-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Stefano,

On 16/07/2015 16:05, Stefano Stabellini wrote:
> I like this. I think it might make sense to call it
> gnttab_page_grant_foreign_access_ref_one to make clear that it is only
> granting the first 4K.

Will do.

> In the future we could introduce a new function, called
> gnttab_page_grant_foreign_access_ref, that grants all 4K in the page.

Unless having a different prototype it won't be possible to do it. This 
is because one ref = one grant. We would need a list of grant.

> In any case
>
> Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Thank you,

-- 
Julien Grall
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 04/20] xen/grant: Add helper  gnttab_page_grant_foreign_access_ref Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-07-16 17:10 +0200
  Re: [Xen-devel] [PATCH v2 04/20] xen/grant: Add helper gnttab_page_grant_foreign_access_ref Julien Grall <julien.grall@citrix.com> - 2015-07-16 18:20 +0200

csiph-web