Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1186007

Re: [PATCH 3/7] x86/vm86: Move userspace accesses to do_sys_vm86()

Show all headers | View raw

On Thu, Jul 16, 2015 at 4:46 AM, Brian Gerst <brgerst@gmail.com> wrote:
> Move the userspace accesses down into the common function in
> preparation for the next set of patches.

Nice!

Could you improve the changelog a bit? You're really changing the way
it works (in a good way).


> -       set_flags(regs->pt.flags, VEFLAGS, X86_EFLAGS_VIF | current->thread.v86mask);
> -       tmp = copy_vm86_regs_to_user(&current->thread.vm86_info->regs, regs);
> -       tmp += put_user(current->thread.screen_bitmap, &current->thread.vm86_info->screen_bitmap);
> -       if (tmp) {
> +       set_flags(regs->pt.flags, VEFLAGS, X86_EFLAGS_VIF | tsk->thread.v86mask);
> +       user = tsk->thread.vm86_info;
> +       put_user_try {

I think that put_user_try/put_user_ex requires access_ok.


> +       get_user_try {
> +               unsigned short seg;

This also needs access_ok, I think.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/7] x86/vm86: Move userspace accesses to do_sys_vm86() Brian Gerst <brgerst@gmail.com> - 2015-07-16 13:50 +0200
  Re: [PATCH 3/7] x86/vm86: Move userspace accesses to do_sys_vm86() Andy Lutomirski <luto@amacapital.net> - 2015-07-16 17:50 +0200
    Re: [PATCH 3/7] x86/vm86: Move userspace accesses to do_sys_vm86() Brian Gerst <brgerst@gmail.com> - 2015-07-16 18:10 +0200

csiph-web