Re: [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs

From	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs
Date	2015-07-16 13:10 +0200
Message-ID	<pMPd7-4Ps-5@gated-at.bofh.it> (permalink)
References	<pLJCN-40p-5@gated-at.bofh.it> <pLJCN-40p-11@gated-at.bofh.it> <pLPfc-7pM-31@gated-at.bofh.it> <pLPoS-7Iq-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Dave Hansen wrote:
> On 07/13/2015 09:53 AM, Oleg Nesterov wrote:
> > On 07/13, Kirill A. Shutemov wrote:
> >>
> >> We don't really need ->vm_ops here: MPX VMA can be detected with VM_MPX
> >> flag. And vma_merge() will not merge MPX VMA with non-MPX VMA, because
> >> ->vm_flags won't match.
> > 
> > Agreed.
> > 
> > I am wondering if something like the patch below (on top of yours) makes
> > sense... Not sure, but mpx_mmap() doesn't look nice too, and with this
> > change we can unexport mmap_region().
> 
> These both look nice to me (and they both cull specialty MPX code which
> is excellent).  I'll run them through a quick test.

Any update?

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/5] Make vma_is_anonymous() reliable "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2015-07-13 13:00 +0200
  [PATCH 4/5] mm, madvise: use vma_is_anonymous() to check for anon VMA "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2015-07-13 13:00 +0200
  [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2015-07-13 13:00 +0200
    Re: [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs Leon Romanovsky <leon@leon.nu> - 2015-07-13 14:10 +0200
      Re: [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2015-07-13 14:40 +0200
        Re: [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs Leon Romanovsky <leon@leon.nu> - 2015-07-13 14:50 +0200
    Re: [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2015-07-16 13:10 +0200
      Re: [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs Dave Hansen <dave.hansen@linux.intel.com> - 2015-07-16 18:00 +0200
        Re: [PATCH 2/5] x86, mpx: do not set ->vm_ops on mpx VMAs "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-07-16 18:10 +0200
          [PATCH 0/1] mm, mpx: add "vm_flags_t vm_flags" arg to  do_mmap_pgoff() Oleg Nesterov <oleg@redhat.com> - 2015-07-17 00:30 +0200
            [PATCH 1/1] mm, mpx: add "vm_flags_t vm_flags" arg to  do_mmap_pgoff() Oleg Nesterov <oleg@redhat.com> - 2015-07-17 00:30 +0200
  [PATCH 3/5] mm: make sure all file VMAs have ->vm_ops set "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2015-07-13 13:00 +0200
  [PATCH 1/5] mm: mark most vm_operations_struct const "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2015-07-13 13:00 +0200
  [PATCH 5/5] mm, memcontrol: use vma_is_anonymous() to check for anon VMA "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2015-07-13 13:00 +0200
    Re: [PATCH 5/5] mm, memcontrol: use vma_is_anonymous() to check for  anon VMA Johannes Weiner <hannes@cmpxchg.org> - 2015-07-13 15:10 +0200

csiph-web