Re: [PATCH] sm750fb: coding style fixes lines over 80 chars

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sm750fb: coding style fixes lines over 80 chars
Date	2015-07-16 06:00 +0200
Message-ID	<pMIv0-3mF-9@gated-at.bofh.it> (permalink)
References	<pMzUJ-7PX-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2015-07-16 at 00:16 +0530, Vinay Simha BN wrote:
> scripts/checkpatch.pl kernel coding style fixes of WARNING

Please don't be a checkpatch robot.

Use tools to prompt your brain, but don't ever turn
your brain off.

> diff --git a/drivers/staging/sm750fb/ddk750_help.h b/drivers/staging/sm750fb/ddk750_help.h


> +/* if 718 big endian turned on,be aware that don't use this driver for general
> +	 use,only for ppc big-endian */
> +#warning "big endian on target cpu and enable nature big endian support of 718
> +	capability !"

Yes, this if #if 0, but it's also obviously incorrect

I didn't look at the rest.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] sm750fb: coding style fixes lines over 80 chars Joe Perches <joe@perches.com> - 2015-07-16 06:00 +0200
  Re: [PATCH] sm750fb: coding style fixes lines over 80 chars Vinay Simha <simhavcs@gmail.com> - 2015-07-17 09:20 +0200

csiph-web