Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1185452

Re: [PATCH v1 3/4] mm/memory-failure: give up error handling for non-tail-refcounted thp

Show all headers | View raw

On Thu, Jul 16, 2015 at 04:33:07AM +0200, Andi Kleen wrote:
> > @@ -909,6 +909,15 @@ int get_hwpoison_page(struct page *page)
> >  	 * directly for tail pages.
> >  	 */
> >  	if (PageTransHuge(head)) {
> > +		/*
> > +		 * Non anonymous thp exists only in allocation/free time. We
> > +		 * can't handle such a case correctly, so let's give it up.
> > +		 * This should be better than triggering BUG_ON when kernel
> > +		 * tries to touch a "partially handled" page.
> > +		 */
> > +		if (!PageAnon(head))
> > +			return 0;
> 
> Please print a message for this case. In the future there will be
> likely more non anonymous THP pages from Kirill's large page cache work
> (so eventually we'll need it)

OK, I'll do this.

Thanks,
Naoya Horiguchi--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 3/4] mm/memory-failure: give up error handling for  non-tail-refcounted thp Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2015-07-16 03:50 +0200
  Re: [PATCH v1 3/4] mm/memory-failure: give up error handling for  non-tail-refcounted thp Andi Kleen <andi@firstfloor.org> - 2015-07-16 04:40 +0200
    Re: [PATCH v1 3/4] mm/memory-failure: give up error handling for  non-tail-refcounted thp Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2015-07-16 04:50 +0200

csiph-web