Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1185139

Re: [PATCH] zsmalloc: use class->pages_per_zspage

Show all headers | View raw

On Thu, Jul 16, 2015 at 09:02:25AM +0900, Sergey Senozhatsky wrote:
> On (07/16/15 08:42), Minchan Kim wrote:
> > There is no need to recalcurate pages_per_zspage in runtime.
> > Just use class->pages_per_zspage to avoid unnecessary runtime
> > overhead.
> > 
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
> > ---
> >  mm/zsmalloc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> > index 27b9661c8fa6..154a30e9c8a8 100644
> > --- a/mm/zsmalloc.c
> > +++ b/mm/zsmalloc.c
> > @@ -1711,7 +1711,7 @@ static unsigned long zs_can_compact(struct size_class *class)
> >  	obj_wasted /= get_maxobj_per_zspage(class->size,
> >  			class->pages_per_zspage);
> >  
> > -	return obj_wasted * get_pages_per_zspage(class->size);
> > +	return obj_wasted * class->pages_per_zspage;
> >  }
> 
> plus __zs_compact():
> 
> @@ -1761,8 +1761,7 @@ static void __zs_compact(struct zs_pool *pool, struct size_class *class)
>  
>                 putback_zspage(pool, class, dst_page);
>                 if (putback_zspage(pool, class, src_page) == ZS_EMPTY)
> -                       pool->stats.pages_compacted +=
> -                               get_pages_per_zspage(class->size);
> +                       pool->stats.pages_compacted += class->pages_per_zspage;
>                 spin_unlock(&class->lock);
>                 cond_resched();
>                 spin_lock(&class->lock);
> 
> 	-ss

Thanks. I sent a v2.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] zsmalloc: use class->pages_per_zspage Minchan Kim <minchan@kernel.org> - 2015-07-16 02:20 +0200

csiph-web