Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1185082

Re: [PATCH 3/4] Input: tsc2005 - simplify drvdata acquisition

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Wed, Jul 15, 2015 at 02:31:07PM -0700, Dmitry Torokhov wrote:
> On Wed, Jul 15, 2015 at 02:13:27PM +0200, Sebastian Reichel wrote:
> > Do not convert device to spi_device just for getting
> > the driver data, since spi_get_drvdata() just calls
> > dev_get_drvdata().
> 
> Even though at the moment they all share the same data I consider them
> logically different and so would prefer not to substityte one for
> another.

I guess your problem is with mixing spi_*_drvdata and dev_*_drvdata
calls? In that case I will also change spi_set_drvdata to
dev_set_drvdata, so that spi_*_drvdata is not used at all.

This will still reduce lines of code and flatten the way for tsc2004
support (which is i2c based).

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] [input] tsc2005 cleanup Sebastian Reichel <sre@kernel.org> - 2015-07-15 14:20 +0200
  [PATCH 1/4] Input: tsc2005 - improve readability of register defines Sebastian Reichel <sre@kernel.org> - 2015-07-15 14:20 +0200
  [PATCH 4/4] Input: tsc2005 - convert to gpiod Sebastian Reichel <sre@kernel.org> - 2015-07-15 14:20 +0200
    Re: [PATCH 4/4] Input: tsc2005 - convert to gpiod Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-07-15 23:40 +0200
      Re: [PATCH 4/4] Input: tsc2005 - convert to gpiod Sebastian Reichel <sre@kernel.org> - 2015-07-16 00:10 +0200
        Re: [PATCH 4/4] Input: tsc2005 - convert to gpiod Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-07-16 02:30 +0200
  [PATCH 2/4] Input: tsc2005 - convert to regmap Sebastian Reichel <sre@kernel.org> - 2015-07-15 14:20 +0200
    Re: [PATCH 2/4] Input: tsc2005 - convert to regmap Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-07-15 23:40 +0200
      Re: [PATCH 2/4] Input: tsc2005 - convert to regmap Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-07-15 23:50 +0200
      Re: [PATCH 2/4] Input: tsc2005 - convert to regmap Sebastian Reichel <sre@kernel.org> - 2015-07-16 00:00 +0200
  [PATCH 3/4] Input: tsc2005 - simplify drvdata acquisition Sebastian Reichel <sre@kernel.org> - 2015-07-15 14:20 +0200
    Re: [PATCH 3/4] Input: tsc2005 - simplify drvdata acquisition Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-07-15 23:40 +0200
      Re: [PATCH 3/4] Input: tsc2005 - simplify drvdata acquisition Sebastian Reichel <sre@kernel.org> - 2015-07-16 00:10 +0200
        Re: [PATCH 3/4] Input: tsc2005 - simplify drvdata acquisition Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-07-16 02:30 +0200

csiph-web