RE: [PATCH] serial: samsung: Remove redundant DEBUG_LL check

From	Kukjin Kim <kgene@kernel.org>
Newsgroups	linux.kernel
Subject	RE: [PATCH] serial: samsung: Remove redundant DEBUG_LL check
Date	2015-07-14 06:50 +0200
Message-ID	<pM0ki-67T-7@gated-at.bofh.it> (permalink)
References	<pLJW9-4m6-7@gated-at.bofh.it> <pLXFM-4oF-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Krzysztof Kozlowski wrote:
> 
> On 13.07.2015 20:18, Javier Martinez Canillas wrote:
> > Commit 84f57d9e3685 ("tty: serial/samsung: fix modular build") fixed
> > build issues when the driver was built as a module. One of those was
> > that printascii is only accessible when the driver is built-in.
> >
> > But there is no need to check for defined(CONFIG_DEBUG_LL) since the
> > SERIAL_SAMSUNG_DEBUG Kconfig symbol already depends on DEBUG_LL.
> >
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Acked-by: Kukjin Kim <kgene@kernel.org>

Thanks,
Kukjin

> >
> > ---
> >
> >  drivers/tty/serial/samsung.c | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Although this redundancy is not harmful the patch seems fine, so:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> Best regards,
> Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] serial: samsung: Remove redundant DEBUG_LL check Javier Martinez Canillas <javier@osg.samsung.com> - 2015-07-13 13:20 +0200
  RE: [PATCH] serial: samsung: Remove redundant DEBUG_LL check Kukjin Kim <kgene@kernel.org> - 2015-07-14 06:50 +0200

csiph-web