Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1183355
| From | Stephen Warren <swarren@wwwdotorg.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2. |
| Date | 2015-07-14 07:20 +0200 |
| Message-ID | <pM0Nk-6x5-9@gated-at.bofh.it> (permalink) |
| References | <pJIrv-2mE-3@gated-at.bofh.it> <pJIrx-2mE-33@gated-at.bofh.it> <pKWC6-8du-9@gated-at.bofh.it> <pKXRv-rQ-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 07/11/2015 01:51 AM, Thomas Gleixner wrote: > On Fri, 10 Jul 2015, Stephen Warren wrote: >> On 07/07/2015 03:13 PM, Eric Anholt wrote: >>> +static struct arm_local_intc intc __read_mostly; >> >> It'd be nice to give everything (types, functions, variables) a >> consistent symbol prefix; bcm2836_arm_irqchip_ sounds like a good >> bikeshed to me, but perhaps just propagating the above arm_local_ to the >> functions too would be good, although that seems to risk symbol name >> collisions with other ARM SoCs. > > Which is irrelevant because its static. Except if you want to look up a symbol name without having to qualify it by filename. Or, does e.g. gdb require statics always be qualified even if they're globally unique? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2. Stephen Warren <swarren@wwwdotorg.org> - 2015-07-14 07:20 +0200
csiph-web