Re: [PATCH 1/2] Add NXP LPC32XX SPI driver

From	Martin Devera <martin.devera@cdi.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] Add NXP LPC32XX SPI driver
Date	2015-07-13 15:00 +0200
Message-ID	<pLLuW-58t-11@gated-at.bofh.it> (permalink)
References	<pLn9g-7fr-7@gated-at.bofh.it> <pLKSe-4Ui-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Paul Bolle wrote:
> (This hit my box with lkml mesages without lkml in the To: header. What
> happened here?)

Ahh, have to check my sending script ..

> On zo, 2015-07-12 at 11:20 +0200, Martin Devera wrote:
>> --- /dev/null
>> +++ b/drivers/spi/spi-lpc32xx.c
> 
>> +#define DRIVER_NAME	"spi-lpc32xx"
> 
>> +MODULE_ALIAS("platform:" DRIVER_NAME);
> 
> This alias seems only useful if there's a corresponding struct
> platform_device. Ie, a struct platform_device with a .name of "spi
> -lpc32xx", which will fire off a "MODALIAS=platform:spi-lpc32xx" uevent
> when it's created.

My fault, thanks for spotting. It is leftover from driver I used
as template...
In any case, I has other comments from Joachim Eastwood thus I plan
to do more cleanup and resubmit the driver later..

thanks,
Martin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] Add NXP LPC32XX SPI driver Martin Devera <devik@cdi.cz> - 2015-07-12 13:00 +0200
  Re: [PATCH 1/2] Add NXP LPC32XX SPI driver Paul Bolle <pebolle@tiscali.nl> - 2015-07-13 14:20 +0200
    Re: [PATCH 1/2] Add NXP LPC32XX SPI driver Martin Devera <martin.devera@cdi.cz> - 2015-07-13 15:00 +0200

csiph-web