RE: [PATCH] Input: wdt87xx_i2c - Change the sleep time to 2500ms after the sw reset

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	"Hn Chen" <hn.chen@weidahitech.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] Input: wdt87xx_i2c - Change the sleep time to 2500ms after the sw reset
Date	Mon, 13 Jul 2015 13:50:02 +0200
Message-ID	<pLKpc-4vn-3@gated-at.bofh.it> (permalink)
References	<pL46C-4hQ-9@gated-at.bofh.it> <pLiVY-4Tx-3@gated-at.bofh.it>
X-Original-To	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>
X-MimeOLE	Produced By Microsoft Exchange V6.5
Content-Class	urn:content-classes:message
MIME-Version	1.0
Content-Type	text/plain; charset="big5"
Content-Transfer-Encoding	8BIT
Thread-Topic	[PATCH] Input: wdt87xx_i2c - Change the sleep time to 2500ms after the sw reset
Thread-Index	AdC8bAfJFAqoI9L+R6OCN9Zc7xXBwAA9YPwQ
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	63
Organization	linux.* mail to news gateway
X-Original-Cc	<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <charliemooney@google.com>
X-Original-Date	Mon, 13 Jul 2015 19:47:03 +0800
X-Original-Message-ID	<1A63A1423E772B419A9D2E882CBCF6C4020A4A95@mail>
X-Original-References	<1436625402-4501-1-git-send-email-hn.chen@weidahitech.com> <20150712062847.GA37026@dtor-ws>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1182748

Show key headers only | View raw

Hi, Dmitry,

Thanks !

BR,
Hn.chen.

-----Original Message-----
From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com] 
Sent: Sunday, July 12, 2015 2:29 PM
To: Hn Chen
Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; charliemooney@google.com
Subject: Re: [PATCH] Input: wdt87xx_i2c - Change the sleep time to 2500ms after the sw reset

On Sat, Jul 11, 2015 at 10:36:42PM +0800, HungNien Chen wrote:
>  The original value is 200ms, it includes the loading fw & boot up to  
> the main function. After that, the main function will do algorithm  
> initialized and touch calibrtion about 1.1 second. The touch  
> calibration will change controller freq to scan the best working freq  
> and it has risk to make the i2c data error when doing fw update.
>  We extend the sleep to 2500ms after the sw reset to skip this period time.
> 
> Signed-off-by: HungNien Chen <hn.chen@weidahitech.com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/wdt87xx_i2c.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/wdt87xx_i2c.c 
> b/drivers/input/touchscreen/wdt87xx_i2c.c
> index b97cb4f..cfd1487 100644
> --- a/drivers/input/touchscreen/wdt87xx_i2c.c
> +++ b/drivers/input/touchscreen/wdt87xx_i2c.c
> @@ -157,6 +157,7 @@
>  /* Controller requires minimum 300us between commands */
>  #define WDT_COMMAND_DELAY_MS		2
>  #define WDT_FLASH_WRITE_DELAY_MS	4
> +#define	WDT_FW_RESET_TIME		2500
>  
>  struct wdt87xx_sys_param {
>  	u16	fw_id;
> @@ -413,7 +414,7 @@ static int wdt87xx_sw_reset(struct i2c_client *client)
>  	}
>  
>  	/* Wait the device to be ready */
> -	msleep(200);
> +	msleep(WDT_FW_RESET_TIME);
>  
>  	return 0;
>  }
> --
> 1.9.1
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Input: wdt87xx_i2c - Change the sleep time to 2500ms after the sw reset HungNien Chen <hn.chen@weidahitech.com> - 2015-07-11 16:40 +0200
  RE: [PATCH] Input: wdt87xx_i2c - Change the sleep time to 2500ms after the sw reset "Hn Chen" <hn.chen@weidahitech.com> - 2015-07-13 13:50 +0200

csiph-web