Re: [PATCH 9/9] MIPS: Remove "__weak" definition from arch-specific linkage.h

From	James Hogan <james.hogan@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 9/9] MIPS: Remove "__weak" definition from arch-specific linkage.h
Date	2015-07-13 12:10 +0200
Message-ID	<pLIQq-3K2-19@gated-at.bofh.it> (permalink)
References	<pLyHn-5YP-3@gated-at.bofh.it> <pLyHn-5YP-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 13/07/15 00:12, Bjorn Helgaas wrote:
> "__weak" is defined in include/linux/compiler-gcc.h.  We shouldn't need an
> arch-specific definition.
> 
> Remove the "__weak" definition from arch/mips/include/asm/linkage.h.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

asm/linkage.h is only included from linux/linkage.h, which includes
linux/compiler.h first, so no chance of build problems AFAICT, therefore:

Reviewed-by: James Hogan <james.hogan@imgtec.com>

Thanks
James

> ---
>  arch/mips/include/asm/linkage.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/linkage.h b/arch/mips/include/asm/linkage.h
> index 2767dda..99651b0 100644
> --- a/arch/mips/include/asm/linkage.h
> +++ b/arch/mips/include/asm/linkage.h
> @@ -5,7 +5,6 @@
>  #include <asm/asm.h>
>  #endif
>  
> -#define __weak __attribute__((weak))
>  #define cond_syscall(x) asm(".weak\t" #x "\n" #x "\t=\tsys_ni_syscall")
>  #define SYSCALL_ALIAS(alias, name)					\
>  	asm ( #alias " = " #name "\n\t.globl " #alias)
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 9/9] MIPS: Remove "__weak" definition from arch-specific  linkage.h Bjorn Helgaas <bhelgaas@google.com> - 2015-07-13 01:20 +0200
  Re: [PATCH 9/9] MIPS: Remove "__weak" definition from arch-specific  linkage.h James Hogan <james.hogan@imgtec.com> - 2015-07-13 12:10 +0200

csiph-web