Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1182573

Re: [PATCH 5/6] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable

Show all headers | View raw

On Saturday 11 July 2015 12:46 PM, Krzysztof Kozlowski wrote:
> W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze:
>> 88PM860 family of device supports dual phase mode on BUCK1 supply
>> providing total 6A capacity.
>> Note that by default they operate independently with 3A capacity.
>>
>> This patch adds the devicetree binding to enable this
>> feature.
>>
>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
>> ---
>>   Documentation/devicetree/bindings/mfd/88pm800.txt | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt
>> index ae1311c..c756b31 100644
>> --- a/Documentation/devicetree/bindings/mfd/88pm800.txt
>> +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt
>> @@ -15,6 +15,12 @@ Optional properties :
>>         CLK32K3 - for 88pm800
>>         CLK32K2 - for 88pm860
>>
>> +   (Applicable only to PXA910 family):
>> +
>> + - marvell,88pm860-buck1-dualphase-en	: If set, enable dual phase on BUCK1,
>> +   providing 6A capacity.
>> +   Without this both BUCK1A and BUCK1B operates independently with 3A capacity.
>> +
>
> 1. How does this relates to regulator driver? The
> drivers/regulator/88pm800.c defines constraints for regulator which may
> be contradictory.
>
> 2. This looks like a job for regulator driver, not MFD. Then you could
> use standard regulator bindings (setting maximum current to 6A would
> change the regulator to different mode).

Make sense. and even better.

I believe you are referring to,

regulator-min-microamp = <3000000>;
regulator-max-microamp = <6000000>;

And provide set_current_limit() callback, to set the dualphase.

Just to clarify more on this,

The DT property would look something like,

regulators {
	compatible = "marvell,88pm80x-regulator";

	buck1a: BUCK1A {
		regulator-compatible = "buck1";
		regulator-min-microvolt = <600000>;
		regulator-max-microvolt = <1800000>;

		regulator-min-microamp = <3000000>;
		regulator-max-microamp = <6000000>;

		regulator-boot-on;
		regulator-always-on;
	};

	buck1b: BUCK1B {
		regulator-compatible = "buck1b";
		regulator-min-microvolt = <600000>;
		regulator-max-microvolt = <1800000>;

		regulator-min-microamp = <3000000>;
		regulator-max-microamp = <6000000>;

		regulator-boot-on;
		regulator-always-on;
	};
};


And for the platforms, where dual phase is not required,
we can either choose not to set these properties or set it to


		regulator-min-microamp = <3000000>;
		regulator-max-microamp = <3000000>;


Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] mfd: 88pm800: Add 88pm860 device support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-09 13:50 +0200
  [PATCH 4/6] mfd: 88pm800: Enable 32KHZ XO low jitter clock out Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-09 14:00 +0200
  [PATCH 3/6] mfd: devicetree: bindings: 88pm800: Add DT property for 32KHz output enable Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-09 14:00 +0200
    Re: [PATCH 3/6] mfd: devicetree: bindings: 88pm800: Add DT property  for 32KHz output enable Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-13 09:30 +0200
      Re: [PATCH 3/6] mfd: devicetree: bindings: 88pm800: Add DT property  for 32KHz output enable Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-13 09:40 +0200
        Re: [PATCH 3/6] mfd: devicetree: bindings: 88pm800: Add DT property  for 32KHz output enable Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-13 09:40 +0200
          Re: [PATCH 3/6] mfd: devicetree: bindings: 88pm800: Add DT property  for 32KHz output enable Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-13 09:50 +0200
  [PATCH 2/6] mfd: 88pm800: Add init time initial configuration support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-09 14:00 +0200
    Re: [PATCH 2/6] mfd: 88pm800: Add init time initial configuration  support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-13 09:20 +0200
  [PATCH 6/6] mfd: 88pm800: Add support for configuration of dual phase on BUCK1 Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-09 14:00 +0200
  [PATCH 1/6] mfd: 88pm80x: Add 88pm860 chip type support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-09 14:00 +0200
  [PATCH 5/6] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-09 14:00 +0200
    Re: [PATCH 5/6] mfd: devicetree: bindings: 88pm800: Add DT property  for dual phase enable Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-13 10:00 +0200
      Re: [PATCH 5/6] mfd: devicetree: bindings: 88pm800: Add DT property  for dual phase enable Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-13 10:20 +0200
  Re: [PATCH 0/6] mfd: 88pm800: Add 88pm860 device support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-09 14:10 +0200
    Re: [PATCH 0/6] mfd: 88pm800: Add 88pm860 device support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-09 14:50 +0200
      Re: [PATCH 0/6] mfd: 88pm800: Add 88pm860 device support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-07-09 15:00 +0200

csiph-web