[RFC 1/3] ftrace: adjust a function's pc to search for in check_stack() for arm64

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	AKASHI Takahiro <takahiro.akashi@linaro.org>
Newsgroups	linux.kernel
Subject	[RFC 1/3] ftrace: adjust a function's pc to search for in check_stack() for arm64
Date	Mon, 13 Jul 2015 07:40:02 +0200
Message-ID	<pLED8-16e-1@gated-at.bofh.it> (permalink)
References	<pLED8-16e-3@gated-at.bofh.it>
X-Original-To	catalin.marinas@arm.com, will.deacon@arm.com, rostedt@goodmis.org
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pZo237xUC4d4GqZcQfMuaDA+jzv4AQkppGDxe9Ucz20=; b=ggj7J4oj8xC6ezYrBCU6cS1aK6ZWhk6NJzj8w1Z4MOTu9DcH2qdFZ9S9pUNODLIJQT PQAmL+VSvhmYD4FSooOLGAUOrN2u0eueD0Vz90KxCTYw8dJzqnCaqCZgkgFUzLCZISzi jiVkA9RQkonAGD/PHksxKvgkL0IsubpzGY62/f1aCNuHuHwAdXQSYxaUs5PojOFty8M0 1mh7LWXP5HtzNKSNH2WOapepjvqf2nW0LEZ8doEGDsB1GWvR65ZLwFi3BzXnGukod0M+ JfNTaEGNVovcQUd8yRQqsmN0IyHpmkZdNwRSaDp26VPb384mI1wgP/vXYfWr/Vp4VDfK Av0A==
X-Gm-Message-State	ALoCoQkfA+3l/iKzHlJROfN0NOqS8QBvlszAvMs7N+yI/1h5agqNdgPCJ9PmUjZOcAeok14qicgG
X-Received	by 10.70.22.235 with SMTP id h11mr66436497pdf.135.1436765431811; Sun, 12 Jul 2015 22:30:31 -0700 (PDT)
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	58
Organization	linux.* mail to news gateway
X-Original-Cc	jungseoklee85@gmail.com, olof@lixom.net, broonie@kernel.org, david.griego@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, AKASHI Takahiro <takahiro.akashi@linaro.org>
X-Original-Date	Mon, 13 Jul 2015 14:29:33 +0900
X-Original-Message-ID	<1436765375-7119-2-git-send-email-takahiro.akashi@linaro.org>
X-Original-References	<1436765375-7119-1-git-send-email-takahiro.akashi@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1182524

Show key headers only | View raw

Ftace's stack tracer on arm64 returns wrong information about call stacks:

        Depth    Size   Location    (50 entries)
        -----    ----   --------
  0)     5256       0   notifier_call_chain+0x30/0x94
  1)     5256       0   ftrace_call+0x0/0x4
  2)     5256       0   notifier_call_chain+0x2c/0x94
  3)     5256       0   raw_notifier_call_chain+0x34/0x44
  4)     5256       0   timekeeping_update.constprop.9+0xb8/0x114
  5)     5256       0   update_wall_time+0x408/0x6dc

Most of 'Size' fields are unexpectedly zero.

This is because stack tracer fails to recognize each function's stack frame
in check_stack(). Stack tracer searches for a function's pc in the stack
based on the list returned by save_stack_trace(), but save_stack_trace() on
arm64 does not return the exact return address saved in a stack frame, but
a value decrmented by 4 (which means a branch instruction's address).
This behavior was introduced by
    commit e306dfd06fcb ("ARM64: unwind: Fix PC calculation")

So the matching doesn't succeed in most cases.

This problem can be fixed either by
a) reverting the commit above
b) adding an arm64-specific hack to check_patch()

This patch does b).

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
 kernel/trace/trace_stack.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c
index 3f34496..7086fc3 100644
--- a/kernel/trace/trace_stack.c
+++ b/kernel/trace/trace_stack.c
@@ -143,7 +143,11 @@ check_stack(unsigned long ip, unsigned long *stack)
 		p = start;
 
 		for (; p < top && i < max_stack_trace.nr_entries; p++) {
+#ifdef CONFIG_ARM64
+			if (*p == (stack_dump_trace[i] + 4)) {
+#else
 			if (*p == stack_dump_trace[i]) {
+#endif
 				this_size = stack_dump_index[i++] =
 					(top - p) * sizeof(unsigned long);
 				found = 1;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC 1/3] ftrace: adjust a function's pc to search for in check_stack() for arm64 AKASHI Takahiro <takahiro.akashi@linaro.org> - 2015-07-13 07:40 +0200
  Re: [RFC 1/3] ftrace: adjust a function's pc to search for in check_stack()  for arm64 AKASHI Takahiro <takahiro.akashi@linaro.org> - 2015-07-15 02:30 +0200

csiph-web