Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1182171

[PATCH 1/2] tracing: Fix function graph duration format for 7-digit number

Show all headers | View raw

Currently, row's width of 7-digit duration numbers not aligned with
other cases like the following example.

 3) $ 3999884 us |      }
 3)               |      finish_task_switch() {
 3)   0.365 us    |        _raw_spin_unlock_irq();
 3)   3.333 us    |      }
 3) $ 3999976 us |    }
 3) $ 3999979 us |  } /* schedule */

As adding a single white space in case of 7-digit numbers, the format
could be unified easily as follows.

 3) $ 2237472 us  |      }
 3)               |      finish_task_switch() {
 3)   0.364 us    |        _raw_spin_unlock_irq();
 3)   3.125 us    |      }
 3) $ 2237556 us  |    }
 3) $ 2237559 us  |  } /* schedule */

Signed-off-by: Jungseok Lee <jungseoklee85@gmail.com>
---
 kernel/trace/trace_functions_graph.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c
index 8968bf7..0bc16c4 100644
--- a/kernel/trace/trace_functions_graph.c
+++ b/kernel/trace/trace_functions_graph.c
@@ -716,6 +716,8 @@ trace_print_graph_duration(unsigned long long duration, struct trace_seq *s)
 		snprintf(nsecs_str, slen, "%03lu", nsecs_rem);
 		trace_seq_printf(s, ".%s", nsecs_str);
 		len += strlen(nsecs_str);
+	} else if (len == 7) {
+		len -= 1;
 	}
 
 	trace_seq_puts(s, " us ");
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Improve trace output format Jungseok Lee <jungseoklee85@gmail.com> - 2015-07-11 17:00 +0200
  [PATCH 1/2] tracing: Fix function graph duration format for 7-digit number Jungseok Lee <jungseoklee85@gmail.com> - 2015-07-11 17:00 +0200
    Re: [PATCH 1/2] tracing: Fix function graph duration format for  7-digit number Steven Rostedt <rostedt@goodmis.org> - 2015-07-17 03:50 +0200

csiph-web