Re: [PATCH v2] coresight: replicator: Use module_platform_driver

From	Vaishali Thakkar <vthakkar1994@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] coresight: replicator: Use module_platform_driver
Date	2015-07-10 05:30 +0200
Message-ID	<pKxaG-wP-11@gated-at.bofh.it> (permalink)
References	<pKq9c-4rN-3@gated-at.bofh.it> <pKqsx-4NO-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 10, 2015 at 1:49 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
>
> On vr, 2015-07-10 at 01:29 +0530, Vaishali Thakkar wrote:
> > --- a/drivers/hwtracing/coresight/coresight-replicator.c
> > +++ b/drivers/hwtracing/coresight/coresight-replicator.c
>
> > -static int __init replicator_init(void)
> > -{
> > -     return platform_driver_register(&replicator_driver);
> > -}
> > -module_init(replicator_init);
> > -
> > -static void __exit replicator_exit(void)
> > -{
> > -     platform_driver_unregister(&replicator_driver);
> > -}
> > -module_exit(replicator_exit);
> > +module_platform_driver(replicator_driver);
>
> coresight-replicator.o is built if CONFIG_CORESIGHT_LINKS_AND_SINKS is
> defined. CORESIGHT_LINKS_AND_SINKS is a bool symbol. It depends on
> CORESIGHT, which is also a bool symbol. CORESIGHT is a top level symbol,
> available on arm and arm64.
>
> I think coresight-replicator.o can only be built-in. So I suggest to use
> builtin_platform_driver() instead.
>

I thought about this solution before sending this patch. But I was not
sure about it. Thanks for the explanation. I will send v3 with this
change.

Can I add Suggested By: Paul Bolle <pebolle@tiscali.nl>


>
> Thanks,
>
>
> Paul Bolle




-- 
Vaishali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] coresight: replicator: Use module_platform_driver Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-07-10 05:30 +0200
  Re: [PATCH v2] coresight: replicator: Use module_platform_driver Paul Bolle <pebolle@tiscali.nl> - 2015-07-10 11:10 +0200
    Re: [PATCH v2] coresight: replicator: Use module_platform_driver Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-07-14 17:30 +0200

csiph-web