Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1181160

[PATCH] zsmalloc: consider ZS_ALMOST_FULL as migrate source

Show all headers | View raw

There is no reason to prevent select ZS_ALMOST_FULL as migration
source if we cannot find source from ZS_ALMOST_EMPTY.

With this patch, zs_can_compact will return more exact result.

Signed-off-by: Minchan Kim <minchan@kernel.org>
---
 mm/zsmalloc.c |   19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 8c78bcb..7bd7dde 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1687,12 +1687,20 @@ static enum fullness_group putback_zspage(struct zs_pool *pool,
 static struct page *isolate_source_page(struct size_class *class)
 {
 	struct page *page;
+	int i;
+	bool found = false;
 
-	page = class->fullness_list[ZS_ALMOST_EMPTY];
-	if (page)
-		remove_zspage(page, class, ZS_ALMOST_EMPTY);
+	for (i = ZS_ALMOST_EMPTY; i >= ZS_ALMOST_FULL; i--) {
+		page = class->fullness_list[i];
+		if (!page)
+			continue;
 
-	return page;
+		remove_zspage(page, class, i);
+		found = true;
+		break;
+	}
+
+	return found ? page : NULL;
 }
 
 /*
@@ -1706,9 +1714,6 @@ static unsigned long zs_can_compact(struct size_class *class)
 {
 	unsigned long obj_wasted;
 
-	if (!zs_stat_get(class, CLASS_ALMOST_EMPTY))
-		return 0;
-
 	obj_wasted = zs_stat_get(class, OBJ_ALLOCATED) -
 		zs_stat_get(class, OBJ_USED);
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] zsmalloc: consider ZS_ALMOST_FULL as migrate source Minchan Kim <minchan@kernel.org> - 2015-07-10 03:40 +0200
  Re: [PATCH] zsmalloc: consider ZS_ALMOST_FULL as migrate source Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-07-10 04:00 +0200
    Re: [PATCH] zsmalloc: consider ZS_ALMOST_FULL as migrate source Minchan Kim <minchan@kernel.org> - 2015-07-10 04:40 +0200
  Re: [PATCH] zsmalloc: consider ZS_ALMOST_FULL as migrate source Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-07-10 04:10 +0200
    Re: [PATCH] zsmalloc: consider ZS_ALMOST_FULL as migrate source Minchan Kim <minchan@kernel.org> - 2015-07-10 04:40 +0200

csiph-web