Re: [PATCH] net: switchdev: don't abort unsupported operations

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Jiri Pirko <jiri@resnulli.us>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: switchdev: don't abort unsupported operations
Date	Sat, 11 Jul 2015 12:00:01 +0200
Message-ID	<pKZJD-1Aw-3@gated-at.bofh.it> (permalink)
References	<pKWVs-8ku-7@gated-at.bofh.it>
X-Original-To	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=5T6Jis32hxCWSBD+V01E7uKj7t9DyWMisMgN1pXtdm4=; b=IwpmbaBFUE1oo9BIrEcEhqw56bzE1IllPXS57Weg5d/Mg5M3tFbAn5PZ4pnjsIKzdN 52LmPHYWTB2w99Kq5XO8W1toxfDCilv90jASB6tri6HkIpfFMRFF5BNCpCEnoOFTQxJo OA2yc+03Hvu9Sk4xofPxYo2xx9sdCfMsrNp4lHvEnpvu0WImYCcac82iLXfjYL31zPwT dm9u59Tn/vS/2J8yqcQcuRHc5LTAmTek45cvP4xb4mzVJ78U1YijN2yLe4Kp1JKRcTYi WBrUKJdPL/b4cGFwJE+ma3VDS0zuZk8Zy+74IYa4riPUgJOTLN7Bu1+0g17UNXIeqFYH bLfg==
X-Gm-Message-State	ALoCoQm54cDsu9Z6DApMT/huadEYXh02s0cVjRLzQj51On6FSkBJF0qPRkVxU99FA/zwn/XpYPr+
X-Received	by 10.180.80.9 with SMTP id n9mr5499464wix.87.1436608553300; Sat, 11 Jul 2015 02:55:53 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	16
Organization	linux.* mail to news gateway
X-Original-Cc	netdev@vger.kernel.org, Scott Feldman <sfeldma@gmail.com>, "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com
X-Original-Date	Sat, 11 Jul 2015 11:55:51 +0200
X-Original-Message-ID	<20150711095551.GA2059@nanopsycho.orion>
X-Original-References	<1436572138-16542-1-git-send-email-vivien.didelot@savoirfairelinux.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1182122

Show key headers only | View raw

Sat, Jul 11, 2015 at 01:48:58AM CEST, vivien.didelot@savoirfairelinux.com wrote:
>There is no need to abort attribute setting or object addition, if the
>prepare phase returned operation not supported.
>
>Thus, abort these two transactions only if the error is not -EOPNOTSUPP.
>
>Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Sounds reasonable.

Acked-by: Jiri Pirko <jiri@resnulli.us>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] net: switchdev: don't abort unsupported operations Jiri Pirko <jiri@resnulli.us> - 2015-07-11 12:00 +0200

csiph-web