Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1181985
| From | Chris Metcalf <cmetcalf@ezchip.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] nohz: prevent tilegx network driver interrupts |
| Date | 2015-07-11 01:10 +0200 |
| Message-ID | <pKPAB-3Im-1@gated-at.bofh.it> (permalink) |
| References | <pKLQm-1rE-17@gated-at.bofh.it> <pKMjn-1C3-9@gated-at.bofh.it> <pKPhg-3mu-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 7/10/2015 6:45 PM, Josh Cartwright wrote:
>> +static inline const struct cpumask *housekeeping_cpumask(void)
>> >+{
>> >+#ifdef CONFIG_NO_HZ_FULL
>> >+ if (tick_nohz_full_enabled())
>> >+ return housekeeping_mask;
>> >+#endif
> Just a small comment:
>
> We can take these checks out from under a #ifdef CONFIG_NO_HZ_FULL
> check, given that are stubbed tick_nohz_full_enabled() defined above.
True for the "if" clause, but the "housekeeping_mask" variable is only defined
under CONFIG_NO_HZ_FULL.
--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2] nohz: prevent tilegx network driver interrupts Josh Cartwright <joshc@ni.com> - 2015-07-11 00:50 +0200
Re: [PATCH v2] nohz: prevent tilegx network driver interrupts Chris Metcalf <cmetcalf@ezchip.com> - 2015-07-11 01:10 +0200
Re: [PATCH v2] nohz: prevent tilegx network driver interrupts Josh Cartwright <joshc@ni.com> - 2015-07-11 01:20 +0200
csiph-web