Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

From	Nicolas Ferre <nicolas.ferre@atmel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function
Date	2015-07-10 18:20 +0200
Message-ID	<pKJbQ-8ea-3@gated-at.bofh.it> (permalink)
References	<pKh5U-7lB-23@gated-at.bofh.it> <pKzFw-2aA-23@gated-at.bofh.it> <pKBnZ-34H-25@gated-at.bofh.it> <pKFhW-5PP-85@gated-at.bofh.it> <pKFKW-61e-1@gated-at.bofh.it>
Organization	atmel

Show all headers | View raw

Le 10/07/2015 14:31, Maxime Ripard a écrit :
> On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote:
>> Hi,
>>
>> On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote :
>>> I would agree with Maxime. Currently all latest chip reset function is
>>> compatible with the atmel,sama5d3-rstc.
>>> So check compatible string is enough for now.
>>> But of cause if we have other incompatible reset in future with new chip,
>>> the structure like you said is needed.
>>
>> We managed to avoid using of_machine_is_compatible() in all the at91
>> drivers. I'd like to keep it that way. It was painful enough to remove
>> all those cpu_is_at91xxx calls.
> 
> That's your call...
> 
>> Also, using it is trying to match strings and will result in longer boot
>> times.
> 
> Have you looked at the implementation of of_match_device? If that's
> really a concern to you, you should actually avoid it.

I agree: let's keep it simple and use of_match_device().

Bye,
-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-07-10 18:20 +0200

csiph-web