Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

From	Guenter <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function
Date	2015-07-10 19:10 +0200
Message-ID	<pKJYe-j1-15@gated-at.bofh.it> (permalink)
References	<pKh5U-7lB-23@gated-at.bofh.it> <pKnXH-34k-3@gated-at.bofh.it> <pKvVf-8dZ-3@gated-at.bofh.it> <pKx10-tH-3@gated-at.bofh.it> <pKzvP-1RQ-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 10, 2015 at 07:56:58AM +0200, Alexandre Belloni wrote:
> Hi Guenter,
> 
> On 09/07/2015 at 20:14:38 -0700, Guenter Roeck wrote :
> > > This patch introduces a new compatible string: "atmel,sama5d3-rstc" for the
> > > reset driver of sama5d3 and later chips.
> > > As in sama5d3 or later chips, we don't have to shutdown the DDR controller
> > > before reset. Shutdown the DDR controller before reset is a workaround to
> > > avoid DDR signal driving the bus, but since sama5d3 and later chips there is
> > > no such a conflict.
> > > That means:
> > >   1. the sama5d3 reset function only need to write the rstc register and
> > > return.
> > >   2. for sama5d3, we can remove the code related with DDR controller as we
> > > don't use it at all.
> > > 
> > Sorry, I don't get it. Doesn't that mean there are two distinct logical
> > changes, which would ask for two separate patches ?
> 
> I would agree with Josh and I think that only one patch is needed. There
> is only one change, the removal of the workaround for sama5d3 and later.
> 
> As the workaround is using a table of compatibles to remap the ram
> controller and the one for sama5d3 is not used because it is not needed,
> I think it makes sense to remove it in that same patch. The logical
> change here is the removal of the workaround.
> 
Ok, makes sense.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function Josh Wu <josh.wu@atmel.com> - 2015-07-10 04:10 +0200
  Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function Guenter Roeck <linux@roeck-us.net> - 2015-07-10 05:20 +0200
    Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function Josh Wu <josh.wu@atmel.com> - 2015-07-10 06:00 +0200
    Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function Guenter <linux@roeck-us.net> - 2015-07-10 19:10 +0200

csiph-web