Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT

Path	csiph.com!aioe.org!eternal-september.org!feeder.eternal-september.org!newsfeed.Update.UU.SE!news.Update.UU.SE!itgate.net!bofh.it!news.nic.it!robomod
From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove EXPERT
Date	Fri, 10 Jul 2015 10:50:02 +0200
Message-ID	<pKCam-3EX-9@gated-at.bofh.it> (permalink)
References	<pKp3r-3HJ-3@gated-at.bofh.it> <pKpd7-3L6-11@gated-at.bofh.it> <pKpGa-4hj-21@gated-at.bofh.it>
X-Original-To	Linus Torvalds <torvalds@linux-foundation.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=FeouVv4MK6vITQvZLxKJo+X1NKje3vy3EvLfH8BlrzI=; b=MFHmRXzVDZNxQTGQbMyYXmAcskq6XGIxU+X9gKOHrwmWEqwL8xDWWnhRQB1Yuu77jf IJAlnbj2Xv8hy5veZusQdxBZ6UlRq0NQ3/u+wtvCt+XbChE05LrGQwAQ47+MA573TvyX PL5bX6dEvJ1NpLi7ckLaFU3tlM71+itQRBEOT1oDX5g7Mi2zQmmPE2ROMHLzchUq3qGO iyj3PiQXeSa49+U+UTtRrPn+OSI3z769cepBNItywjFsktFNWAJ9txpOxVTGfP+ma10b Ohmlai29Lj+ic9kOCOQDRZDCekP+q3Ty/+GIvSY0k6OlYPLBpx7e4uO/fysrJVmzgNZm Xu1g==
X-Received	by 10.194.200.73 with SMTP id jq9mr37868905wjc.52.1436517920513; Fri, 10 Jul 2015 01:45:20 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	Arjan van de Ven <arjan@linux.intel.com>, Andy Lutomirski <luto@kernel.org>, the arch/x86 maintainers <x86@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Oleg Nesterov <oleg@redhat.com>, Kees Cook <keescook@chromium.org>, Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>, Austin S Hemmelgarn <ahferroin7@gmail.com>, Brian Gerst <brgerst@gmail.com>, Matthew Garrett <mjg59@srcf.ucam.org>
X-Original-Date	Fri, 10 Jul 2015 10:45:16 +0200
X-Original-Message-ID	<20150710084516.GA15959@gmail.com>
X-Original-References	<dae7c0f1282a92e5eeac8b9fc389e2a02051d9cb.1436467147.git.luto@kernel.org> <559EC297.3030901@linux.intel.com> <CA+55aFzdBf4GPyR-+FRy3PkBdvp0f7PJ1xCx6SSUU=WN=PvUzw@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1181386

Show key headers only | View raw

* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> [...]
> 
> The one thing we might want to do is to rename the config option, simply to make 
> sure that people who do "make oldconfig" will actually see the new question and 
> hopefully pick the new default rather than just getting their old "y" without 
> even seeing it. Call the option "LEGACY_VM86" or something, perhaps?

Absolutely!

The 'default n' makes very little sense without changing the name - most distros 
have the old symbol already and will just grandfather in at whatever value it was.

Change the name and also update the help text to make it scarier: point out that 
it has known quirks and that we don't really trust the code because it's ancient, 
crippled on the hardware side because vm86 mode was never fully documented by CPU 
makers, back when x86 CPU makers (and Microsoft) considered virtualization an 
enemy of Windows revenue.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] x86/kconfig/32: Make CONFIG_VM86 default to n and remove  EXPERT Ingo Molnar <mingo@kernel.org> - 2015-07-10 10:50 +0200

csiph-web