Re: [PATCH 0/4] ARM: dts: Use labels instead of full paths for Exynos5 pinctrl nodes

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/4] ARM: dts: Use labels instead of full paths for Exynos5 pinctrl nodes
Date	2015-07-09 02:00 +0200
Message-ID	<pK7pT-1br-1@gated-at.bofh.it> (permalink)
References	<pJQfn-77A-3@gated-at.bofh.it> <pJSTU-m3-13@gated-at.bofh.it> <pJYmD-3LX-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08.07.2015 23:15, Javier Martinez Canillas wrote:
> Krzysztof,
> 
> On 07/08/2015 01:27 AM, Krzysztof Kozlowski wrote:
>> On 08.07.2015 14:36, Javier Martinez Canillas wrote:
>>> Hello Kukjin and Krzysztof,
>>>
>>> This is a trivial series that changes Exynos5 pinctrl dtsi files to extend
>>> the pinctrl nodes using labels instead of full paths.
>>>
>>> Using labels is less error prone since a misstyped label leads to a build
>>> error while full paths can lead to the creation of a new node instead of
>>> overriding the original which makes the mistake harder to detect.
>>>
>>> I tested the changes by decompiling the Exynos5* dtbs and comparing before
>>> and after. The resulting dts were identical modulo some node ordering due
>>> the pinctrl include change.
>>
>> Is the DTB before and after the same? It should not change by re-ordering.
>>
> 
> The DTB differ but I'm not that familiar with how dtc represents the FDT
> to know what is changing in the binary.
> 
> But as mentioned, the decompiled DTS only changes in which position the
> pinctrl are defined and both DTS are identical if I do:
> 
> $ cat decompiled.dts | sort

Right, the DTB may differ because of change of definition's location. If
sorting fixes this then I'm convinced.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 0/4] ARM: dts: Use labels instead of full paths for  Exynos5 pinctrl nodes Javier Martinez Canillas <javier@osg.samsung.com> - 2015-07-08 16:20 +0200
  Re: [PATCH 0/4] ARM: dts: Use labels instead of full paths for Exynos5  pinctrl nodes Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-09 02:00 +0200

csiph-web