Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1180296

Re: [patch v2 2/3] mm, oom: organize oom context into struct

Show all headers | View raw

On Thu, 2 Jul 2015, Michal Hocko wrote:

> On Wed 01-07-15 14:37:14, David Rientjes wrote:
> > The force_kill member of struct oom_control isn't needed if an order of
> > -1 is used instead.  This is the same as order == -1 in
> > struct compact_control which requires full memory compaction.
> > 
> > This patch introduces no functional change.
> 
> But it obscures the code and I really dislike this change as pointed out
> previously.
> 

The oom killer is often called at the end of a very lengthy stack since 
memory allocation itself can be called deep in the stack.  Thus, reducing 
the amount of memory, even for a small lil bool, is helpful.  This is 
especially true when other such structs, struct compact_control, does the 
exact same thing by using order == -1 to mean explicit compaction.

I'm personally tired of fixing stack overflows and you're arguing against 
"obscurity" that even occurs in other parts of the mm code.  
oc->force_kill has no reason to exist, and thus it's removed in this patch 
and for good reason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch v2 1/3] mm, oom: organize oom context into struct David Rientjes <rientjes@google.com> - 2015-07-01 23:40 +0200
  [patch v2 2/3] mm, oom: organize oom context into struct David Rientjes <rientjes@google.com> - 2015-07-01 23:40 +0200
    Re: [patch v2 2/3] mm, oom: organize oom context into struct David Rientjes <rientjes@google.com> - 2015-07-09 01:30 +0200
  [patch v2 3/3] mm, oom: organize oom context into struct David Rientjes <rientjes@google.com> - 2015-07-01 23:40 +0200
  [patch v3 1/3] mm, oom: organize oom context into struct David Rientjes <rientjes@google.com> - 2015-07-09 01:50 +0200
    [patch v3 2/3] mm, oom: pass an oom order of -1 when triggered by  sysrq David Rientjes <rientjes@google.com> - 2015-07-09 01:50 +0200
    [patch v3 3/3] mm, oom: do not panic for oom kills triggered from  sysrq David Rientjes <rientjes@google.com> - 2015-07-09 01:50 +0200
    Re: [patch v3 1/3] mm, oom: organize oom context into struct David Rientjes <rientjes@google.com> - 2015-07-15 01:50 +0200

csiph-web