Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1177956

Re: [PATCH] input: misc: bma150: use sign_extend32() for sign extending

Show all headers | View raw

On Fri, Jul 03, 2015 at 01:13:01AM +0200, Martin Kepplinger wrote:
> Despite it's name, sign_extend32() is used for 16 bit values aswell.
> 
> Signed-off-by: Martin Kepplinger <martink@posteo.de>

Applied, thank you.

> ---
>  drivers/input/misc/bma150.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/input/misc/bma150.c b/drivers/input/misc/bma150.c
> index b36831c..c278049 100644
> --- a/drivers/input/misc/bma150.c
> +++ b/drivers/input/misc/bma150.c
> @@ -333,10 +333,9 @@ static void bma150_report_xyz(struct bma150_data *bma150)
>  	y = ((0xc0 & data[2]) >> 6) | (data[3] << 2);
>  	z = ((0xc0 & data[4]) >> 6) | (data[5] << 2);
>  
> -	/* sign extension */
> -	x = (s16) (x << 6) >> 6;
> -	y = (s16) (y << 6) >> 6;
> -	z = (s16) (z << 6) >> 6;
> +	x = sign_extend32(x, 9);
> +	y = sign_extend32(y, 9);
> +	z = sign_extend32(z, 9);
>  
>  	input_report_abs(bma150->input, ABS_X, x);
>  	input_report_abs(bma150->input, ABS_Y, y);
> -- 
> 2.1.4
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] input: misc: bma150: use sign_extend32() for sign extending Martin Kepplinger <martink@posteo.de> - 2015-07-03 01:20 +0200
  Re: [PATCH] input: misc: bma150: use sign_extend32() for sign  extending Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-07-07 01:00 +0200

csiph-web