Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1179771

Re: [RFC PATCH v3 1/4] STM trace event: Adding generic buffer interface driver

Show all headers | View raw

Peter Zijlstra <peterz@infradead.org> writes:

> On Tue, Jul 07, 2015 at 06:10:40PM +0800, Chunyan Zhang wrote:
>> +config STM_TRACE_EVENT
>> +	tristate "Redirect/copy the output from kernel trace event to STM engine"
>
> How does tristate make sense here? You're using it unconditionally for
> in-kernel tracepoints. This must be bool, which in turn makes the whole
> STM thing bool afaiu.

That would make the whole STM thing a bool. I'd rather we used stm
output *conditionally* by somehow plugging into tracepoint output, say
with a jump label or something. Haven't had time to think about it yet.

Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v3 1/4] STM trace event: Adding generic buffer interface driver Chunyan Zhang <zhang.chunyan@linaro.org> - 2015-07-07 12:20 +0200
  Re: [RFC PATCH v3 1/4] STM trace event: Adding generic buffer interface driver Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2015-07-08 15:10 +0200
  Re: [RFC PATCH v3 1/4] STM trace event: Adding generic buffer  interface driver Mathieu Poirier <mathieu.poirier@linaro.org> - 2015-07-08 16:20 +0200

csiph-web