Re: [PATCH V3 1/4] perf: Add PERF_RECORD_SWITCH to indicate context switches

Path	csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3 1/4] perf: Add PERF_RECORD_SWITCH to indicate context switches
Date	Wed, 08 Jul 2015 15:30:01 +0200
Message-ID	<pJXAd-3fG-9@gated-at.bofh.it> (permalink)
References	<pJwA1-3g3-9@gated-at.bofh.it> <pJwJI-3ot-19@gated-at.bofh.it> <pJB6G-69E-29@gated-at.bofh.it> <pJBq1-6gd-11@gated-at.bofh.it> <pJD8v-7nV-41@gated-at.bofh.it> <pJDLb-7RF-15@gated-at.bofh.it> <pJK0h-39I-5@gated-at.bofh.it>
X-Original-To	Peter Zijlstra <peterz@infradead.org>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
X-URL	http://acmel.wordpress.com
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	Adrian Hunter <adrian.hunter@intel.com>, Andi Kleen <ak@linux.intel.com>, Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>, Stephane Eranian <eranian@google.com>, mathieu.poirier@linaro.org, Pawel Moll <pawel.moll@arm.com>
X-Original-Date	Wed, 8 Jul 2015 10:28:05 -0300
X-Original-Message-ID	<20150708132805.GC3243@kernel.org>
X-Original-References	<1436258202-6540-1-git-send-email-adrian.hunter@intel.com> <1436258202-6540-2-git-send-email-adrian.hunter@intel.com> <20150707132552.GA3326@kernel.org> <20150707134437.GC3326@kernel.org> <20150707153614.GT3644@twins.programming.kicks-ass.net> <20150707161359.GL3326@kernel.org> <20150707225240.GW3644@twins.programming.kicks-ass.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1179809

Show key headers only | View raw

Em Wed, Jul 08, 2015 at 12:52:40AM +0200, Peter Zijlstra escreveu:
> On Tue, Jul 07, 2015 at 01:13:59PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jul 07, 2015 at 05:36:14PM +0200, Peter Zijlstra escreveu:
> > > > To help userspace in places where all it has is the union perf_event, we
> > > > can reuse one bit in misc to state that, i.e.

> > > >   #define PERF_RECORD_MISC_SWITCH_NEXT_PREV_PID 14
 
> > > > For instance.

> > > The other option would be a separate RECORD type, which might be
> > > simpler.

> > Humm, do we really need it?

> > I think this is just us wanting to, since we are going to add a new
> > record, to make it more useful for other, not right now needed,
> > situations, i.e. if the user is priviledged, there are two other options
> > to get his info, right?
 
> I was just thinking that 2 records, each with a fixed layout would be
> easier to parse than 1 record with variable layout.
 
> The record space is immense, so from that point it really doesn't
> matter.

We could do a land grab at some point there, if/when we find some reason
for that... :-)
 
> Do whatever is easiest, less mistakes get made etc. :-)
 
> No real preference either way, as long we we've thought about it.

Right, I just don't want to have two u32 carrying -1 for no reason.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH V3 1/4] perf: Add PERF_RECORD_SWITCH to indicate context  switches Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-07-07 18:20 +0200
  Re: [PATCH V3 1/4] perf: Add PERF_RECORD_SWITCH to indicate context  switches Peter Zijlstra <peterz@infradead.org> - 2015-07-08 01:00 +0200
    Re: [PATCH V3 1/4] perf: Add PERF_RECORD_SWITCH to indicate context  switches Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-07-08 15:30 +0200
      Re: [PATCH V3 1/4] perf: Add PERF_RECORD_SWITCH to indicate context  switches Adrian Hunter <adrian.hunter@intel.com> - 2015-07-08 15:50 +0200

csiph-web