Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1179807

Re: [PATCH v3 2/3] megaraid_sas : use dev_printk when possible

Show all headers | View raw

On Wed, Jul 8, 2015 at 5:47 AM, Hannes Reinecke <hare@suse.de> wrote:
> On 07/07/2015 10:52 PM, Bjorn Helgaas wrote:
>> Use dev_printk() when possible to make messages more useful.
>>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>> ---
>>  drivers/scsi/megaraid/megaraid_sas_base.c   |  304 +++++++++++++--------------
>>  drivers/scsi/megaraid/megaraid_sas_fusion.c |   95 ++++----
>>  2 files changed, 196 insertions(+), 203 deletions(-)
>>
> [ .. ]
>> @@ -1873,8 +1872,8 @@ static int megasas_get_ld_vf_affiliation_111(struct megasas_instance *instance,
>>       cmd = megasas_get_cmd(instance);
>>
>>       if (!cmd) {
>> -             printk(KERN_DEBUG "megasas: megasas_get_ld_vf_affiliation_111:"
>> -                    "Failed to get cmd for scsi%d.\n",
>> +             dev_printk(KERN_DEBUG, &instance->pdev->dev, "megasas_get_ld_vf_affiliation_111:"
>> +                    "Failed to get cmd for scsi%d\n",
>>                       instance->host->host_no);
>>               return -ENOMEM;
>>       }
> Makes one wonder why we don't have a 'dev_debug'; dev_notice() and
> dev_warn() are there ...

There actually is a 'dev_dbg()' but when CONFIG_DYNAMIC_DEBUG is set,
I think dev_dbg() generates no output by default.  So to preserve the
previous behavior of "this message always appears in the dmesg log no
matter what the dynamic debug setting," I used dev_printk(KERN_DEBUG).

Somebody who maintains these drivers could probably go through and
convert these to either dev_info() or dev_dbg() depending on what they
need.  That would require more judgment than I wanted to get into :)

Thanks for taking a look at these!

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3 2/3] megaraid_sas : use dev_printk when possible Bjorn Helgaas <bhelgaas@google.com> - 2015-07-08 15:30 +0200

csiph-web