Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1179735

Re: [RFC PATCH v3 4/4] trace: Trace log handler for logging into STM blocks

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [RFC PATCH v3 4/4] trace: Trace log handler for logging into STM blocks
Date Wed, 08 Jul 2015 14:40:02 +0200
Message-ID <pJWNQ-2GX-9@gated-at.bofh.it> (permalink)
References <pJy8N-4of-5@gated-at.bofh.it> <pJy8N-4of-3@gated-at.bofh.it>
X-Original-To Chunyan Zhang <zhang.chunyan@linaro.org>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.21 (2012-12-30)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 29
Organization linux.* mail to news gateway
X-Original-Cc rostedt@goodmis.org, mingo@redhat.com, mathieu.poirier@linaro.org, serge.broslavsky@linaro.org, broonie@kernel.org, alexander.shishkin@linux.intel.com, zhang.lyra@gmail.com, linux-kernel@vger.kernel.org
X-Original-Date Wed, 8 Jul 2015 14:31:48 +0200
X-Original-Message-ID <20150708123148.GF12596@twins.programming.kicks-ass.net>
X-Original-References <cover.1436262902.git.zhang.chunyan@linaro.org> <a1bde0b882e36eb81579e9fb6d2561bdfaee4c06.1436262902.git.zhang.chunyan@linaro.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref aioe.org linux.kernel:1179735

Show key headers only | View raw


On Tue, Jul 07, 2015 at 06:10:43PM +0800, Chunyan Zhang wrote:
> Add the function 'trace_event_stm_output_##call' for printing events
> trace log into STM blocks.
> 
> This patch also adds a function call at where the events have been
> committed to ring buffer to export the trace event information to
> STM blocks.

So then you have two copies of the data, why that? Would a scheme were
data either goes to the STM or the regular buffer not make much more
sense?

> +++ b/include/trace/perf.h
> @@ -175,6 +175,7 @@ trace_event_raw_event_##call(void *__data, proto)			\
>  	{ assign; }							\
>  									\
>  	trace_event_buffer_commit(&fbuffer);				\
> +	trace_event_stm_log(&fbuffer);					\

This makes every trace event slower.

>  }
>  /*
>   * The ftrace_test_probe is compiled out, it is only here as a build time check
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH v3 4/4] trace: Trace log handler for logging into STM blocks Chunyan Zhang <zhang.chunyan@linaro.org> - 2015-07-07 12:20 +0200
  Re: [RFC PATCH v3 4/4] trace: Trace log handler for logging into STM  blocks Peter Zijlstra <peterz@infradead.org> - 2015-07-08 14:40 +0200
    Re: [RFC PATCH v3 4/4] trace: Trace log handler for logging into STM blocks Chunyan Zhang <zhang.chunyan@linaro.org> - 2015-07-08 15:10 +0200
      Re: [RFC PATCH v3 4/4] trace: Trace log handler for logging into STM  blocks Ingo Molnar <mingo@kernel.org> - 2015-07-08 15:30 +0200
    Re: [RFC PATCH v3 4/4] trace: Trace log handler for logging into  STM blocks Steven Rostedt <rostedt@goodmis.org> - 2015-07-08 15:20 +0200
      Re: [RFC PATCH v3 4/4] trace: Trace log handler for logging into STM blocks Chunyan Zhang <zhang.chunyan@linaro.org> - 2015-07-10 11:10 +0200
      Re: [RFC PATCH v3 4/4] trace: Trace log handler for logging into STM blocks Chunyan Zhang <zhang.chunyan@linaro.org> - 2015-07-17 08:00 +0200

csiph-web