Re: [PATCH 3/3] kmod: Remove unecessary explicit wide CPU affinity setting

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] kmod: Remove unecessary explicit wide CPU affinity setting
Date	Tue, 07 Jul 2015 19:50:01 +0200
Message-ID	<pJFah-ap-13@gated-at.bofh.it> (permalink)
References	<pJgEV-1IY-3@gated-at.bofh.it> <pJgEV-1IY-1@gated-at.bofh.it> <pJE4A-7Yw-69@gated-at.bofh.it> <pJEHh-8rS-15@gated-at.bofh.it> <pJF0B-6Z-1@gated-at.bofh.it>
X-Original-To	Frederic Weisbecker <fweisbec@gmail.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.18 (2008-05-17)
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.24
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	33
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, Christoph Lameter <cl@linux.com>, Rik van Riel <riel@redhat.com>, Andrew Morton <akpm@linux-foundation.org>
X-Original-Date	Tue, 7 Jul 2015 19:38:55 +0200
X-Original-Message-ID	<20150707173855.GA21133@redhat.com>
X-Original-References	<1436196821-13962-1-git-send-email-fweisbec@gmail.com> <1436196821-13962-4-git-send-email-fweisbec@gmail.com> <20150707163030.GA16647@redhat.com> <20150707171014.GH20498@lerouge> <20150707173644.GA20422@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1178802

Show key headers only | View raw

On 07/07, Oleg Nesterov wrote:
>
> On 07/07, Frederic Weisbecker wrote:
> >
> >
> > People who want CPU isolation will likely write
> > /sys/devices/virtual/workqueue/cpumask to a reduced set of CPUs, typically
> > CPU 0 that is used for housekeeping in nohz full.
>
> Well, khelper_wq is not WQ_SYSFS, so I am not sure this is possible.

Please ignore, I see the new "workqueue: Create low-level unbound
workqueues cpumask" commit...


> But this doesn't really matter, people can change cpu affinity. But
> "workqueues are handled by housekeeping CPUs" doesn't look right.
>
> > In fact we should add the code which initialize wq_unbound_cpumask
> > to housekeeping_mask automatically.
>
> Perhaps, but until then the changelog above looks really confusing,
> as if workqueue.c already does this automagically ;)

Yes.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/3] kmod: Remove unecessary explicit wide CPU affinity  setting Oleg Nesterov <oleg@redhat.com> - 2015-07-07 18:40 +0200
  Re: [PATCH 3/3] kmod: Remove unecessary explicit wide CPU affinity  setting Frederic Weisbecker <fweisbec@gmail.com> - 2015-07-07 19:20 +0200
    Re: [PATCH 3/3] kmod: Remove unecessary explicit wide CPU affinity  setting Oleg Nesterov <oleg@redhat.com> - 2015-07-07 19:40 +0200
      Re: [PATCH 3/3] kmod: Remove unecessary explicit wide CPU affinity  setting Oleg Nesterov <oleg@redhat.com> - 2015-07-07 19:50 +0200

csiph-web