Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.

From	Jeremy White <jwhite@codeweavers.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect USB devices over IP.
Date	2015-07-07 18:50 +0200
Message-ID	<pJEee-824-17@gated-at.bofh.it> (permalink)
References	(2 earlier) <pHdrP-gp-3@gated-at.bofh.it> <pHh2p-64r-9@gated-at.bofh.it> <pHj4e-yA-7@gated-at.bofh.it> <pHsAy-72O-15@gated-at.bofh.it> <pHsTU-7pb-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>>
>> Well, the checkpatch.pl reports were all style (and mostly whitespace);
>> roughly 3000 of them against 3000 lines of code :-/.  I did review the
>> code, looking for areas where I thought it would badly cram into the
>> kernel, and I adjusted the few I found (and sent changes upstream).
> 
> style matters, as it's a thing with your brain.  You learn patterns and
> if the patterns change, you have to do more work and don't see the real
> issues involved.  So by ignoring our style you are saying you don't want
> anyone else in the kernel community to ever review or work on the code,
> which isn't ok.

Looks like I can't side step this unless Hans is willing to shift the
usbredir project entirely to using kernel style :-/.

I will plan to make changes so that checkpatch runs clean; I lay out my
concerns and my plan below to make sure I'm taking the best path.

My main concern with changing the ~2,500 lines of code from the upstream
usbredir project is that it will increase the odds that I will introduce
errors, both initially, and again later as I review and attempt to relay
patches from the upstream.

To summarize the checkpatch reports:  the biggest issue is whitespace,
which shouldn't be a problem; I should be able to automate that without
error.  There are also a fair number of one offs; FSF address, space
after '!', etc.  I hope to persuade Hans to take a few style only
patches upstream to address those.  That leaves a pack of about 60 brace
placement and line length issues.

I will plan to manually change those prior to submission.  Any upstream
changes that affect the same code will be manually corrected as well,
prior to submission.

Make sense?

Cheers,

Jeremy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/1] RFC - Implement a usbredir kernel module Jeremy White <jwhite@codeweavers.com> - 2015-07-01 00:10 +0200
  Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to  remotely connect USB devices over IP. "Daniel P. Berrange" <berrange@redhat.com> - 2015-07-01 11:10 +0200
    Re: [Spice-devel] [RFC PATCH 1/1] Add a usbredir kernel module to  remotely connect USB devices over IP. Oliver Neukum <oneukum@suse.com> - 2015-07-02 10:50 +0200
  Re: [RFC PATCH 1/1] Add a usbredir kernel module to remotely connect  USB devices over IP. Jeremy White <jwhite@codeweavers.com> - 2015-07-07 18:50 +0200

csiph-web