Re: [PATCH] clk: at91: Silence warnings and cleanup __init usage

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: at91: Silence warnings and cleanup __init usage
Date	2015-07-07 19:20 +0200
Message-ID	<pJEHi-8rS-39@gated-at.bofh.it> (permalink)
References	<pJkpc-41v-17@gated-at.bofh.it> <pJllf-4BT-1@gated-at.bofh.it> <pJmhk-5dm-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 06/07/2015 at 14:37:59 -0700, Stephen Boyd wrote :
> 
> Ok I can fix the alignment at the same time.
> 

Thanks :)

> ---8<---
> From: Stephen Boyd <sboyd@codeaurora.org>
> Subject: [PATCH] clk: at91: Silence warnings and cleanup __init usage
> 
> Remove useless ifdefs around function prototypes to silence the
> following sparse warnings when the configs aren't enabled.
> 
> drivers/clk/at91/clk-h32mx.c:95:13: warning: symbol
> 'of_sama5d4_clk_h32mx_setup' was not declared. Should it be
> static?
> drivers/clk/at91/clk-utmi.c:159:13: warning: symbol
> 'of_at91sam9x5_clk_utmi_setup' was not declared. Should it be
> static?
> 
> Plus, using __init in function prototypes doesn't do anything, so
> just drop it throughout this file.
> 
> Cc: Boris BREZILLON <boris.brezillon@free-electrons.com>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>


-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] clk: at91: Silence warnings and cleanup __init usage Stephen Boyd <sboyd@codeaurora.org> - 2015-07-06 23:40 +0200
  Re: [PATCH] clk: at91: Silence warnings and cleanup __init usage Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-07-07 19:20 +0200
  Re: [PATCH] clk: at91: Silence warnings and cleanup __init usage Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-07-07 20:00 +0200

csiph-web