RE: [f2fs-dev] [PATCH 12/12] f2fs: use extent_cache by default

From	Chao Yu <yuchaochina@hotmail.com>
Newsgroups	linux.kernel
Subject	RE: [f2fs-dev] [PATCH 12/12] f2fs: use extent_cache by default
Date	2015-07-04 08:40 +0200
Message-ID	<pIphg-22U-9@gated-at.bofh.it> (permalink)
References	<pGM8h-2I8-11@gated-at.bofh.it> <pGMhY-2Tw-33@gated-at.bofh.it> <pHLWy-2FP-17@gated-at.bofh.it> <pIo1Q-1nP-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Jaegeuk,

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Saturday, July 04, 2015 1:16 PM
> To: Chao Yu
> Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net
> Subject: Re: [f2fs-dev] [PATCH 12/12] f2fs: use extent_cache by default

[snip]

> > > @@ -237,10 +237,11 @@ void update_inode(struct inode *inode, struct page *node_page)
> > >  	ri->i_size = cpu_to_le64(i_size_read(inode));
> > >  	ri->i_blocks = cpu_to_le64(inode->i_blocks);
> > >
> > > -	read_lock(&F2FS_I(inode)->ext_lock);
> > > -	set_raw_extent(&F2FS_I(inode)->ext, &ri->i_ext);
> > > -	read_unlock(&F2FS_I(inode)->ext_lock);
> > > -
> > > +	if (F2FS_I(inode)->extent_tree)
> >
> > Could extent cache destroy after above check?
> 
> I don't think so.
> 
> The extent_tree is assigned as one way.
> Once it is assigned, it will be deallocated only after evict_inode.

Previously, I suspected that ->write_inode and ->evict will be executed
concurrently.

After checking the code, I find that would not happen, so we are safe.

Thanks,

> 
> Thanks,
> 
> >
> > Thanks,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

RE: [f2fs-dev] [PATCH 12/12] f2fs: use extent_cache by default Chao Yu <yuchaochina@hotmail.com> - 2015-07-02 14:40 +0200
  RE: [f2fs-dev] [PATCH 12/12] f2fs: use extent_cache by default Chao Yu <yuchaochina@hotmail.com> - 2015-07-04 08:40 +0200

csiph-web