Re: [PATCH 36/51] writeback: implement bdi_for_each_wb()

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 36/51] writeback: implement bdi_for_each_wb()
Date	2015-07-03 19:10 +0200
Message-ID	<pIcDn-2PO-13@gated-at.bofh.it> (permalink)
References	<pt2wi-1zh-3@gated-at.bofh.it> <pt2G0-1Lc-61@gated-at.bofh.it> <pHkD0-27B-15@gated-at.bofh.it> <pHCqe-58n-5@gated-at.bofh.it> <pI8gq-8sL-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 03, 2015 at 02:26:27PM +0200, Jan Kara wrote:
> That's a good point. Thanks for explanation. Maybe add a comment like:
> /*
>  * We use use this seemingly complicated 'for' loop so that 'break' and
>  * 'continue' continue to work as expected.
>  */

This kinda feel superflous for me.  This is something true for all
iteration wrappers which falls within the area of well-established
convention, I think.  If it's doing something weird like combining
if-else clause to do post-conditional processing, sure, but this is
really kinda standard.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 36/51] writeback: implement bdi_for_each_wb() Jan Kara <jack@suse.cz> - 2015-07-01 09:30 +0200
  Re: [PATCH 36/51] writeback: implement bdi_for_each_wb() Tejun Heo <tj@kernel.org> - 2015-07-03 19:10 +0200

csiph-web