Re: [RFC 5/8] kmsg: device support in mem class

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [RFC 5/8] kmsg: device support in mem class
Date	Fri, 03 Jul 2015 17:40:01 +0200
Message-ID	<pIbeh-1No-7@gated-at.bofh.it> (permalink)
References	<pI6Rj-7tK-3@gated-at.bofh.it> <pI6Rk-7tK-15@gated-at.bofh.it>
X-Original-To	Marcin Niesluchowski <m.niesluchow@samsung.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23+89 (0255b37be491) (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	55
Organization	linux.* mail to news gateway
X-Original-Cc	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>, Petr Mladek <pmladek@suse.cz>, Tejun Heo <tj@kernel.org>, Kay Sievers <kay@vrfy.org>, Andrew Morton <akpm@linux-foundation.org>, Joe Perches <joe@perches.com>, Karol Lewandowski <k.lewandowsk@samsung.com>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
X-Original-Date	Fri, 3 Jul 2015 08:39:00 -0700
X-Original-Message-ID	<20150703153900.GB11227@kroah.com>
X-Original-References	<1435920595-30879-1-git-send-email-m.niesluchow@samsung.com> <1435920595-30879-6-git-send-email-m.niesluchow@samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1176671

Show key headers only | View raw

On Fri, Jul 03, 2015 at 12:49:52PM +0200, Marcin Niesluchowski wrote:
> Mem class is current class in which kmsg device is holded in.
> 
> Mem class is exteded by kmsg_sys devices handling.
> 
> Signed-off-by: Marcin Niesluchowski <m.niesluchow@samsung.com>
> ---
>  drivers/char/mem.c | 20 ++++++++++++++++++--
>  1 file changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/mem.c b/drivers/char/mem.c
> index e518040..8d5ba0d 100644
> --- a/drivers/char/mem.c
> +++ b/drivers/char/mem.c
> @@ -815,7 +815,11 @@ static int memory_open(struct inode *inode, struct file *filp)
>  
>  	minor = iminor(inode);
>  	if (minor >= ARRAY_SIZE(devlist))
> +#ifdef CONFIG_PRINTK
> +		minor = KMSG_MINOR;
> +#else
>  		return -ENXIO;
> +#endif

Ick, you are going to have to come up with a better api if you want this
to be able to be merged.  I don't want to see #ifdef in .c files, as
these changes just make things much messier.

> @@ -837,8 +841,20 @@ static const struct file_operations memory_fops = {
>  
>  static char *mem_devnode(struct device *dev, umode_t *mode)
>  {
> -	if (mode && devlist[MINOR(dev->devt)].mode)
> -		*mode = devlist[MINOR(dev->devt)].mode;
> +	int minor;
> +
> +	if (!mode)
> +		return NULL;
> +
> +	minor = MINOR(dev->devt);
> +
> +#ifdef CONFIG_PRINTK
> +	if (minor >= ARRAY_SIZE(devlist))
> +		kmsg_sys_mode(minor, mode);
> +	else
> +#endif

Ick, not ok.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC 5/8] kmsg: device support in mem class Marcin Niesluchowski <m.niesluchow@samsung.com> - 2015-07-03 13:00 +0200
  Re: [RFC 5/8] kmsg: device support in mem class Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-07-03 17:40 +0200

csiph-web