Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1176700

Re: [PATCH] scsi: storvsc: make INQUIRY response SPC-compliant

Show all headers | View raw

On Wed, Jul 01, 2015 at 11:04:08AM +0200, Vitaly Kuznetsov wrote:
> SPC-2/3/4 specs state that "The standard INQUIRY data (see table ...)
> shall contain at least 36 bytes". Hyper-V host doesn't always honor this
> requirement, e.g. when there is no physical device present at a particular
> LUN host sets Peripheral qualifier to 011b and Additional length to 0
> (thus making the reply 5-bytes long). Upper level SCSI stack complains
> with 'INQUIRY result too short (5), using 36'. Fix the issue by mangling
> Additional length field in host's reply at the driver level.

This looks like a big mess, and usage of phys_to_virt is not generally
safe to start with.

If HyperV really is that broken the warning seems correct, but if you
really have to get rid of it we could add a blist flag to not issue
the warning in the core code instead of hacking around it in the driver.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: storvsc: make INQUIRY response SPC-compliant Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-07-01 11:10 +0200
  Re: [PATCH] scsi: storvsc: make INQUIRY response SPC-compliant Christoph Hellwig <hch@infradead.org> - 2015-07-03 18:20 +0200
    RE: [PATCH] scsi: storvsc: make INQUIRY response SPC-compliant KY Srinivasan <kys@microsoft.com> - 2015-07-03 18:30 +0200

csiph-web