Re: [PATCH 2/4] hvc_dcc: don't ignore errors during initialization

From	Timur Tabi <timur@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] hvc_dcc: don't ignore errors during initialization
Date	2015-07-03 16:50 +0200
Message-ID	<pIarU-1ha-35@gated-at.bofh.it> (permalink)
References	<pHbgm-5xn-7@gated-at.bofh.it> <pHbgo-5xn-59@gated-at.bofh.it> <pHA53-3sw-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Jul 1, 2015, at 7:54 PM, Stephen Boyd wrote:

>> 
>> +	/* Returns -1 if error */
>> +	ret = hvc_instantiate(0, 0, &hvc_dcc_get_put_ops);
>> +
>> +	return ret < 0 ? -ENODEV : 0;
> 
> Why not just return the value that hvc_instantiate returns? And maybe we
> should change those -1 in hvc_instantiate into -EPERM?

Well, I didn't want to change common HVC code.  I would have to change all the other drivers that call hvc_instatiate as well.  I agree that returning -1 is bad, but fixing that is something that should be done in another patch.

>> 
>> -	hvc_alloc(0, 0, &hvc_dcc_get_put_ops, 128);
>> -	return 0;
>> +	p = hvc_alloc(0, 0, &hvc_dcc_get_put_ops, 128);
>> +
>> +	return IS_ERR(p) ? PTR_ERR(p) : 0;
> 
> return PTR_ERR_OR_ZERO()?

Yes, thanks.  I'll change it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/4] hvc_dcc: bind driver to core0 for reads and writes Timur Tabi <timur@codeaurora.org> - 2015-06-30 23:30 +0200
  [PATCH 2/4] hvc_dcc: don't ignore errors during initialization Timur Tabi <timur@codeaurora.org> - 2015-06-30 23:30 +0200
    Re: [PATCH 2/4] hvc_dcc: don't ignore errors during initialization Stephen Boyd <sboyd@codeaurora.org> - 2015-07-02 02:00 +0200
      Re: [PATCH 2/4] hvc_dcc: don't ignore errors during initialization Timur Tabi <timur@codeaurora.org> - 2015-07-03 16:50 +0200
  Re: [PATCH 1/4] hvc_dcc: bind driver to core0 for reads and writes Stephen Boyd <sboyd@codeaurora.org> - 2015-07-01 03:40 +0200
    Re: [PATCH 1/4] hvc_dcc: bind driver to core0 for reads and writes Timur Tabi <timur@codeaurora.org> - 2015-07-01 04:00 +0200
      Re: [PATCH 1/4] hvc_dcc: bind driver to core0 for reads and writes Stephen Boyd <sboyd@codeaurora.org> - 2015-07-02 01:40 +0200
        Re: [PATCH 1/4] hvc_dcc: bind driver to core0 for reads and writes Timur Tabi <timur@codeaurora.org> - 2015-07-03 16:50 +0200

csiph-web